Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes DeepSeek MTP speculative decoding correctness issues and refactors speculative sampling/logits processing to reduce duplicated logic and align shapes/flows between prefill vs decoding.
Changes:
- Simplifies AR-spec extra-input slicing so
target_logitsis passed through in the model’s native flattened form. - Refactors speculative rejection sampling to run
FusedLogitsProcessorinline (and removes the dedicatedasync_sampling_logitshelper), plus fixes a duplicatemrope_pos_ids += 1increment. - Fixes DeepSeek MTP proposer to propagate
target_hidden_statesfor subsequent speculative decoding steps (instead of reusing draft hidden states).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lmdeploy/pytorch/strategies/ar_spec/model_agent.py | Adjusts target_logits slicing to pass through flattened logits directly. |
| lmdeploy/pytorch/spec_decode/spec_agent.py | Refactors logits processing within _rejection_sampling, removes duplicate mRoPE increment, and adds profiling scope. |
| lmdeploy/pytorch/spec_decode/proposers/deepseek_mtp.py | Uses model_inputs.target_hidden_states (sliced by last-token indices) for MTP continuation steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grimoire
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modification
Fix mtp:
lmdeploy/pytorch/spec_decode/spec_agent.pylmdeploy/pytorch/spec_decode/proposers/deepseek_mtp.pyimprovement
oc results
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist