[ci] change test whl into python 312 and use test images by zhulinJulia24 · Pull Request #4513 · InternLM/lmdeploy

zhulinJulia24 · 2026-04-09T08:26:43Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

Copilot

Pull request overview

This PR updates the CI/e2e test setup to build and test Python 3.12 wheels, switch several workflows to use configurable “test” Docker images, and adjusts parts of the autotest suite/configs to fit the new environment.

Changes:

Update GitHub Actions workflows to build artifacts for py312, download the matching artifact name, and add docker_tag (and result_tag for benchmark) inputs for container selection/reporting.
Adjust autotest configs/model lists and quantization model selection logic (AWQ/GPTQ/W8A8) to better align with supported models/environments.
Modify/remove certain RESTful tests and relax/adjust a few assertions and prompt cases.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
autotest/utils/pipeline_chat.py	Tweaks pipeline output assertions for intermediate elements.
autotest/utils/config_utils.py	Refactors quantization model list selection across backends/types.
autotest/tools/restful/test_restful_chat_hf_turbomind_llm.py	Removes reasoning/tools RESTful test coverage; keeps core chat/logprobs coverage.
autotest/tools/restful/test_restful_chat_hf_pytorch_llm.py	Removes reasoning/tools RESTful test coverage; keeps core chat + distributed/speculative coverage hooks.
autotest/tools/common_case_config.py	Updates models and gates speculative decoding RESTful cases by `TEST_ENV`.
autotest/prompt_case.yml	Expands memory-test keyword expectations.
autotest/interface/restful/test_restful_generate.py	Updates `stop_token_ids` test payload for additional token id.
autotest/interface/restful/test_restful_completions_v1.py	Loosens batch prompt-order assertions to tolerate output variance.
autotest/interface/restful/test_restful_chat_completions_v1.py	Slightly relaxes token-length bounds for ignore-eos streaming.
autotest/config_5080_legacy.yml	Adjusts quantization allow/deny lists for legacy 5080 environment.
.github/workflows/mllm_api_eval.yml	Switches wheel build/artifact to `py312`.
.github/workflows/evaluate.yml	Switches wheel build/artifact to `py312` and adds configurable container tag.
.github/workflows/docker_nightly.yml	Updates inner-registry nightly tag to `nightly-test-cu12.8`.
.github/workflows/daily_ete_test.yml	Switches wheel build/artifact to `py312`, adds configurable container tag, adjusts cleanup/installs.
.github/workflows/daily_ete_test_5080.yml	Switches wheel build/artifact to `py312`, adds configurable container tag, adjusts installs.
.github/workflows/daily_ete_test_3090.yml	Switches wheel build/artifact to `py312`, adds configurable container tag, updates container image reference.
.github/workflows/benchmark.yml	Switches wheel build/artifact to `py312`, adds configurable container tag and Feishu upload path via `result_tag`.
.github/workflows/api_eval.yml	Switches wheel build/artifact to `py312`.

Comments suppressed due to low confidence (2)

.github/workflows/api_eval.yml:65

The build matrix was switched to py312, but this workflow installs the produced wheel inside openmmlab/lmdeploy:latest-cu12.8 containers and still uses COV_PARAM pointing at a Python 3.10 site-packages path. Please confirm the container image is Python 3.12-compatible (otherwise cp312 wheel install will fail) and update COV_PARAM (or compute it dynamically) to match the runtime Python version.

  linux-build:
    if: ${{github.event_name == 'schedule' || (!cancelled() && !inputs.offline_mode)}}
    strategy:
      matrix:
        pyver: [py312]
    runs-on: ubuntu-latest
    env:
      PYTHON_VERSION: ${{ matrix.pyver }}
      PLAT_NAME: manylinux2014_x86_64

.github/workflows/mllm_api_eval.yml:66

The build matrix was switched to py312, but this workflow installs the produced wheel inside openmmlab/lmdeploy:latest-cu12.8 containers and still uses COV_PARAM pointing at a Python 3.10 site-packages path. Please confirm the container image is Python 3.12-compatible (otherwise cp312 wheel install will fail) and update COV_PARAM (or compute it dynamically) to match the runtime Python version.

jobs:
  linux-build:
    if: ${{ !cancelled() }}
    strategy:
      matrix:
        pyver: [py312]
    runs-on: ubuntu-latest
    env:
      PYTHON_VERSION: ${{ matrix.pyver }}
      PLAT_NAME: manylinux2014_x86_64
      DOCKER_TAG: cuda12.8

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T08:33:16Z

autotest/utils/pipeline_chat.py

            result &= len(output.token_ids) > 0
    else:
-        result &= len(output.text) > 0
+        result &= len(output.text) >= 0


len(output.text) >= 0 is a no-op (always true for any non-None string) and significantly weakens this assertion compared to the previous > 0 check. If the intent is to allow empty chunks (e.g., for streaming), consider checking output.text is not None (or isinstance(output.text, str)) and gating the non-empty requirement based on is_stream / is_last rather than removing the validation entirely.

Suggested change

result &= len(output.text) >= 0

result &= isinstance(output.text, str)

if not is_stream:

result &= len(output.text) > 0

Copilot · 2026-04-09T08:33:17Z

autotest/interface/restful/test_restful_generate.py

    def test_stop_token_ids(self):
        print(f'\n[Model: {self.model_name}] Running stop_token_ids test')
-        payload = {'prompt': 'Once upon a time', 'max_tokens': 500, 'stop_token_ids': [11, 281], 'stream': False}
+        # 27974 for internlm3,
+        payload = {
+            'prompt': 'Once upon a time',
+            'max_tokens': 500,
+            'stop_token_ids': [11, 281, 128131],
+            'stream': False
+        }


The stop_token_ids payload was updated, but the inline comment and the log message below still reference the old list ([11, 281]) and a different InternLM3 token id (27974). This makes failures hard to diagnose. Please update the comment and the printed/error strings to reflect the actual stop_token_ids being sent (including the new id).

autotest/tools/common_case_config.py

autotest/tools/restful/test_restful_chat_hf_turbomind_llm.py

autotest/tools/restful/test_restful_chat_hf_pytorch_llm.py

.github/workflows/daily_ete_test.yml

zhulinJulia24 and others added 24 commits March 23, 2026 14:36

update

06e1e61

update

28be81d

updaste

f9d3559

update

5ae3ec3

update

af03b7c

update

5ffd66e

Merge branch 'InternLM:main' into async_result_auto

80d4104

update

dd66f35

update

7abb292

Merge branch 'InternLM:main' into async_result_auto

31cb598

update

9299555

merge main

f0e3648

update

d46fff0

Merge branch 'InternLM:main' into async_result_auto

199bbd0

Update daily_ete_test.yml

0259853

Update daily_ete_test.yml

81bf59e

Update artifact name to use Python 3.12

475b94f

Merge branch 'InternLM:main' into async_result_auto

fdd6b66

update

7d674a0

Merge branch 'InternLM:main' into async_result_auto

64083a2

update main

d747351

update

2b3ac36

update

42d8f50

update

8f94dd0

Copilot AI review requested due to automatic review settings April 9, 2026 08:26

Copilot started reviewing on behalf of zhulinJulia24 April 9, 2026 08:27 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

zhulinJulia24 and others added 3 commits April 9, 2026 18:26

test

f553c66

update

d9a7859

Merge branch 'InternLM:main' into async_result_auto

8e7690b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] change test whl into python 312 and use test images#4513

[ci] change test whl into python 312 and use test images#4513
zhulinJulia24 wants to merge 27 commits intoInternLM:mainfrom
zhulinJulia24:async_result_auto

zhulinJulia24 commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zhulinJulia24 commented Apr 9, 2026

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants