Skip to content

Fix for Issue #2504 (partial): In GRAPHER when a DISPLAYLINKFN is specified but not defined uses the default DRAWLINK #2564

Merged
masinter merged 1 commit intomasterfrom
fgh_grapher-linkdisplayfn
Apr 25, 2026
Merged

Fix for Issue #2504 (partial): In GRAPHER when a DISPLAYLINKFN is specified but not defined uses the default DRAWLINK #2564
masinter merged 1 commit intomasterfrom
fgh_grapher-linkdisplayfn

Conversation

@fghalasz
Copy link
Copy Markdown
Member

In GRAPHER when a DISPLAYLINKFN is specified but not defined, uses the default DRAWLINK function instead and promptprints a message to that effect.

…d function is not defined, it uses the default DRAWLINK function instead and promptprints a notice.
@pamoroso
Copy link
Copy Markdown
Member

With this PR I can open the file glossary.tedit of issue #2504 and scroll to the bottom of it with no issues.

@rmkaplan
Copy link
Copy Markdown
Contributor

Same comment I made to Herb: You should wrap the new references to DRAWLINE in FUNCTION, not QUOTE, for Masterscope.

@masinter
Copy link
Copy Markdown
Member

use IL:FUNCTION and not CL:FUNCTION (which is what #' expands to).

CL:FUNCTION actually fetches CL:SYMBOL-FUNCTION of its argument.

@masinter
Copy link
Copy Markdown
Member

seems like this is OK, should add a new issue to review auto-load mechanism

Copy link
Copy Markdown
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't really tested but looks good -- leaves question of how to deal with unloaded notecards image objects.

@masinter masinter merged commit 0317fbd into master Apr 25, 2026
@masinter masinter linked an issue Apr 25, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken TEdit files in NoteCards documentation

4 participants