Make autoMerge way more readable#4037
Open
Langomatisch wants to merge 1 commit intoIntellectualSites:mainfrom
Open
Make autoMerge way more readable#4037Langomatisch wants to merge 1 commit intoIntellectualSites:mainfrom
Langomatisch wants to merge 1 commit intoIntellectualSites:mainfrom
Conversation
Member
|
Have you tested it ? |
Author
Yes i have tested it on a local server |
Member
|
If you have some time over and be cool when you can add it for this an unit test 👍🏻 |
Author
|
Sure thing! I will do that in the evening :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I find it difficult to work with PlotModificationManager#autoMerge because the code is full of code-duplications.
This way its more readable and needs to be less maintained.
Description
I removed all code-duplications out of that method.
Submitter Checklist
@since TODO.