docs: rewrite README to match the repo as it actually is - #25
Conversation
The layout diagram described a `skills/insta/` tree that does not exist — the skill lives at the repository root as `insta/` — and it omitted two of the seven references (frameworks.md, mcp.md). The install section still offered a planned `insta skills pull` command and told readers to copy from that nonexistent path. - Fix the tree: real paths, all seven references, one line each on what they cover. - Replace the install section with what works today: `insta setup agent` (installs user-globally for every agent and registers MCP), `npx skills add`, or a manual copy. - Document the prod/staging split: prod reads main, staging reads #devel, and the `@ref` form silently resolves to the default branch. - Note that cli-reference.md is the canonical CLI surface doc that insta-cli links to, so changes have to land here. - Add the license section; the repo is Apache-2.0.
jwfing
left a comment
There was a problem hiding this comment.
Review: docs — rewrite README to match the repo
Summary: A documentation-only rewrite of README.md (1 file, +83/−29) whose every factual claim I was able to verify against the real repo and the companion insta-cli source — it is accurate and a clear improvement over the drifted original.
Requirements context
No docs/superpowers/ (or other spec/plan) directory exists in insta-skills — this is a docs/skills repo with no spec dir or test harness — so I assessed against the PR description, the actual repo layout, and the companion insta-cli implementation (the source of truth for the CLI behavior the README documents). Companion PR InsForge/insta-cli#68 is open, as the body states.
Findings
Critical
(none)
Functionality — I confirmed each substantive claim in the new README against the checked-out head and the insta-cli repo:
- Layout/tree — accurate. Skill lives at repo root
insta/(noskills/dir);insta/SKILL.md,insta/cli-reference.md, and exactly 7 references present (setup, deploy, frameworks, branching, governance, operate, mcp). ✓ - Environments —
prod → InsForge/insta-skills(main) andstaging → InsForge/insta-skills#develmatchinsta-cli/src/env.tsENVSexactly, and thedevelbranch does exist on this remote. ✓ #refvs@reftrap — matches theenv.tsskillsfield doc-comment verbatim:@is parsed as a skill-name filter, silently leaving the source on the default branch while still echoing the ref. The README's warning is correct (and, notably, more consistent than a couple ofinsta-cli's own@refcomments). ✓- Install paths —
insta setup agentinstalls user-globally for every agent (setupArgs→-g -a '*') and registers the MCP server (registerMcp) ininsta-cli/src/commands/setup.ts;npx skills add InsForge/insta-skills -s instamatches the real invocation.insta project create/linkinstall the stack skills (Neon/Tigris/Better Auth) viainstallSkills(src/commands/project.ts:68,86). ✓ - Canonical
cli-reference.md— confirmed byinsta-cli/AGENTS.md:16("Command/flag changes must be mirrored in.../cli-reference.md"). ✓ - License — repo ships an Apache-2.0
LICENSE. ✓
Security / Performance — No security- or performance-relevant changes; this PR only edits Markdown. No secrets, dependencies, or code paths touched.
Software engineering — No tests apply (docs repo, no test harness), and no coding-standard concerns in a Markdown edit.
Suggestion
(none)
Information
README.md(removed lines 47-48 of the old file): theinsta observeclaim was dropped, not "kept." The PR body says "One existing claim checked out and is kept: theinsta observecredential-audit hook really is installed automatically … (project.tscallsinstallObserve)." The diff removes that sentence and does not re-add it anywhere in the new README. The underlying fact is still true (insta-cli/src/commands/project.ts:20callsinstallObserveon create), so this is a loss of accurate, useful information rather than an error — worth a one-line mention under Install if the omission was unintentional. Purely editorial; accept or ignore.- Intro (
README.md:9-11) vs. tree: the intro says skills "work in … anything else that reads askills/directory," while the whole rewrite (correctly) establishes that this repo has noskills/directory (the skill is at rootinsta/). The twoskills/references mean different things (the agent's install destination vs. this repo's layout), which is fine, but a reader coming for the "there is noskills/" correction may find the juxtaposition mildly confusing. Trivial.
Verdict
approved (informational; a human still gives the explicit GitHub approval). Zero Critical findings — an accurate, well-scoped docs fix. The two Information notes are optional polish.
The rewrite dropped it. The hook really is installed automatically on `insta project create` / `link` — project.ts calls installObserve — so the note belongs next to the install instructions.
Two of the seven references (deploy.md, frameworks.md) are about shipping code, and the summary did not say so.
Companion to InsForge/insta-cli#68. Both repos are public and both READMEs had drifted.
What was wrong
skills/insta/…. The skill lives at the repository root asinsta/; there is noskills/directoryreferences/frameworks.mdandreferences/mcp.mdwere absent from the tree; there are seven, not fiveinsta skills pull, and told readers tocp -r skills/instafrom a path that does not existmainwhile staging reads#develOne existing claim checked out and is kept: the
insta observecredential-audit hook really is installed automatically oninsta project create/link(project.tscallsinstallObserve).What it says now
Install covers the three paths that work today —
insta setup agent(user-global for every agent, plus MCP registration),npx skills add InsForge/insta-skills -s insta, and a manual copy.The tree is real, with a line per reference on what it covers, checked against each file.
A new Environments section documents the prod/staging split, including the
#refversus@reftrap thatenv.tswarns about:@is parsed as a skill-name filter, so it silently resolves to the default branch while still echoing the ref back.The section on
cli-reference.mdnow states that it is the canonical CLI surface doc and thatinsta-cli's README links here for flags instead of keeping a second copy. That is the arrangementinsta-cli/AGENTS.mdalready requires, and companion PR #68 makes it explicit on the other side.Summary by cubic
Rewrite README to reflect the real
insta/skill layout, current install paths, and environment behavior, and makecli-reference.mdthe canonical CLI reference. Fixes incorrect paths and obsolete commands, adds missing references, restores theinsta observenote, adds license, and updates the one‑line summary to mention deploying.insta/; lists all sevenreferences/*with one-line summaries.insta setup agent(user‑global + MCP),npx skills add InsForge/insta-skills -s insta, or manual copy; notes thatinsta project create/linkinstall stack skills and theinsta observecredential-audit hook.main, staging reads#devel; warn to use#ref(not@ref).cli-reference.mdis the canonical CLI doc;insta-clilinks here for flags.Written for commit a72791e. Summary will update on new commits.