fix(deployments): tolerate transient gateway 5xx during deploy status polling

src/commands/deployments/deploy-poll.test.ts

@@ -0,0 +1,67 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { CLIError } from '../../lib/errors.js';
+
+const ossMock = vi.hoisted(() => ({
+  ossFetch: vi.fn(),
+}));
+vi.mock('../../lib/api/oss.js', () => ossMock);
+
+import { pollDeployment } from './deploy.js';
+
+const POLL_INTERVAL_MS = 5_000;
+
+function jsonResponse(body: unknown): Response {
+  return new Response(JSON.stringify(body), {
+    status: 200,
+    headers: { 'Content-Type': 'application/json' },
+  });
+}
+
+function deploymentResponse(status: string, extra: Record<string, unknown> = {}): Response {
+  return jsonResponse({ id: 'dep_1', status, url: null, metadata: null, ...extra });
+}
+
+beforeEach(() => {
+  vi.useFakeTimers();
+  ossMock.ossFetch.mockReset();
+});
+
+afterEach(() => {
+  vi.useRealTimers();
+});
+
+describe('pollDeployment', () => {
+  it('keeps polling through a transient gateway 502 and resolves once READY', async () => {
+    ossMock.ossFetch
+      .mockResolvedValueOnce(deploymentResponse('BUILDING'))
+      .mockRejectedValueOnce(new CLIError('OSS request failed: 502', 1, undefined, 502))
+      .mockResolvedValueOnce(deploymentResponse('READY', { url: 'https://app.vercel.app' }));
+
+    const promise = pollDeployment('dep_1', null, false);
+    await vi.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 3);
+
+    const result = await promise;
+    expect(result.isReady).toBe(true);
+    expect(result.liveUrl).toBe('https://app.vercel.app');
+    expect(ossMock.ossFetch).toHaveBeenCalledTimes(3);
+  });
+
+  it('still fails fast on 4xx status responses', async () => {
+    ossMock.ossFetch.mockRejectedValueOnce(new CLIError('Deployment not found.', 1, 'NOT_FOUND', 404));
+
+    const promise = pollDeployment('dep_1', null, false);
+    const assertion = expect(promise).rejects.toThrow('Deployment not found.');
+    await vi.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+    await assertion;
+    expect(ossMock.ossFetch).toHaveBeenCalledTimes(1);
+  });
+
+  it('still fails when the deployment itself reports ERROR', async () => {
+    ossMock.ossFetch.mockResolvedValueOnce(deploymentResponse('ERROR'));
+
+    const promise = pollDeployment('dep_1', null, false);
+    const assertion = expect(promise).rejects.toThrow('Deployment failed with status: ERROR');
+    await vi.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+    await assertion;
+  });
+});

src/commands/deployments/deploy.ts

@@ -277,7 +277,7 @@ async function startDirectDeployment(
   await response.json();
 }
 
-async function pollDeployment(
+export async function pollDeployment(
   deploymentId: string,
   spinner: ReturnType<typeof clack.spinner> | null | undefined,
   syncBeforeRead: boolean,
@@ -310,7 +310,13 @@ async function pollDeployment(
       const elapsed = Math.round((Date.now() - startTime) / 1000);
       spinner?.message(`Building and deploying... (${elapsed}s, status: ${deployment.status})`);
     } catch (err) {
-      if (err instanceof CLIError) throw err;
+      // Deployment-failure errors (thrown above, no statusCode) and 4xx
+      // responses are terminal. Gateway 5xx responses on the status endpoint
+      // are transient — the deployment itself may still succeed — so keep
+      // polling, same as network-level fetch errors.
+      if (err instanceof CLIError && (err.statusCode === undefined || err.statusCode < 500)) {
+        throw err;
+      }
       // Ignore transient fetch errors during polling
     }
   }