(WIP) Modernize CMake Buildsystem#10936
Draft
jschmidt-icinga wants to merge 10 commits into
Draft
Conversation
jschmidt-icinga
force-pushed
the
modernize-cmake
branch
9 times, most recently
from
9eb77fd to
d228b06
Compare
The Boost::thread CMake target depends on it. Actually it's needed only on *suse*:15.*, but can't harm having it on the other GHAs too.
This is required for the new unity builds because it is not guaranteed that a source file that includes `i2-base.hpp`, which includes `win32.hpp` is at the very start of each unity build file. This would otherwise cause syntax errors like `C2589` when C++ constructs like `std::min()` or `std::numeric_limits<T>::max()` are used because `windows.h` without `NOMINMAX` defined will define `min()` and `max()` macros.
jschmidt-icinga
force-pushed
the
modernize-cmake
branch
from
d228b06 to
690aa07
Compare
jschmidt-icinga
force-pushed
the
modernize-cmake
branch
from
690aa07 to
ec46bb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early test to see what the CI says.
Todo
mkclasswork directly with targets