Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
# Wheel __version__ gate lives in one place — verified before publish runs.
verify:
needs: resolve
uses: Icaro0310/devin-powerups/.github/workflows/verify-wheel-version.yml@7db127668a6b5c3fa396a4853dcf25865e3a4d2c # v1
uses: Icaro0310/devin-powerups/.github/workflows/verify-wheel-version.yml@41ac6d43b44e6bb1984c95f63f69ce18abfe1329 # v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Publishing verifier upgrade lacks changelog entry

Repinning verify-wheel-version leaves the publishing gate change out of the root changelog, contrary to the changelog rule.

Learn more

The reusable verifier now installs different wheel-checking tools, but this PR changes only its pin. The contribution checklist requires a semver changelog update before a PR. The root Unreleased section has no entry for this upgrade.

Example: A maintainer reviewing the Unreleased notes sees the previous publish workflow changes but cannot identify when the verifier switched to Twine 7 and pinned packaging 26.3.

Recommended fix: Add a concise CI or Publish entry to the root CHANGELOG.md Unreleased section describing the verifier pin update and its publishing-gate effect.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1c8ae12 — Unreleased CI entry added for the verifier pin update.

with:
package-dir: ${{ needs.resolve.outputs.dir }}
module: ${{ needs.resolve.outputs.mod }}
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

- **CI** — `pypi-publish.yml` verifier pin updated (Twine 6.1.0 →
7.0.0 + packaging pin via reusable verify-wheel-version); publish
gate unchanged (Dependabot PR #100).
- **CI** — `test-office.yml` gains a `quickstart` job that smoke-tests
the `packages/office` README quick start end to end on
`windows-latest` + `ubuntu-latest`: `pip install -e .`, daemon up on
Expand Down
Loading