Minor changes to meet ruff 0.15 standards and fix some preview issues#1185
Open
oerc0122 wants to merge 1 commit intoISISNeutronMuon:protosfrom
Open
Minor changes to meet ruff 0.15 standards and fix some preview issues#1185oerc0122 wants to merge 1 commit intoISISNeutronMuon:protosfrom
oerc0122 wants to merge 1 commit intoISISNeutronMuon:protosfrom
Conversation
b92fbc2 to
76832ad
Compare
76832ad to
5703fe7
Compare
Collaborator
|
As far as I can tell, the vector shell plots (in the q vector widget) don't work in this branch. That is, I can show the vectors preview showing the shell population, but the other tab with vector distribution within the shell throws an exception: |
Collaborator
|
I also think that the play button in the trajectory view doesn't work after the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Miscellaneous changes to meet Ruff 0.l5 specs and fix some of the issues raised by the
preview=TrueFixes
N/A
To test
Tests should pass.