Migrate to new header format#15
Merged
Merged
Conversation
Jack-J-Day
reviewed
Jun 15, 2026
Jack-J-Day
reviewed
Jun 15, 2026
Jack-J-Day
reviewed
Jun 15, 2026
Jack-J-Day
left a comment
Jack-J-Day
left a comment
Collaborator
There was a problem hiding this comment.
Few queries:
Do we have enough metrics on why the code would be rejecting UDP Frame Headers -> Are we happy with some of them being grouped?
uAH scaling -> does this need to be configured for TS1/TS2 values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
event_udp_to_kafkato the new header format as documented by ISISComputingGroup/ibex_developers_manual#205 .In particular, this changes the packet-parsing to be based on lengths from headers, which should be much more robust than scanning for
0xFFFFFFFFwords and assuming that those delimit messages.Breaking change: parsing "old" packets will now be broken, we require the new data length field in the header.
Closes ISISComputingGroup/DataStreaming#55