Feature/workflow runner overrides with vars#109
Open
Jacko50 wants to merge 11 commits into
Open
Conversation
Contributor
|
Hi @Jacko50, please redo this without the formatting changes as it makes the review and the merging hard (we have a conflict now). Also, the branch should be created from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the deployment image workflow to support configurable runners and a clear product-vs-project registry model, while keeping backward-compatible defaults.
What Changed
extract-version->extract-variablesneedsand output references accordingly.project_image_prefixwith fallback.project_repository(defaultmyproject)product_repository_prefix(defaultreleases_)Why
The workflow had outgrown the original “single registry + fixed naming” assumptions. This change makes it reusable across environments where:
without requiring template code edits.
Backward Compatibility
registry_username/registry_passwordremain valid fallback credentials.harbor.delivery.iqgeo.cloud.Suggested GitHub Configuration (Optional)
If needed, set these repository/environment variables and secrets:
Vars:
product_registryproject_registryproduct_registry_usernameproject_registry_usernameproject_repositoryproject_image_prefixproduct_repository_prefixamd64_runner,arm64_runner(if used)Secrets:
product_registry_passwordproject_registry_passwordregistry_password(fallback)Validation