Skip to content

Getter and setter addition for saturation. Enchanted golden apple works#963

Open
ZloyNick wants to merge 2 commits into
Hydreon:masterfrom
ZloyNick:master
Open

Getter and setter addition for saturation. Enchanted golden apple works#963
ZloyNick wants to merge 2 commits into
Hydreon:masterfrom
ZloyNick:master

Conversation

@ZloyNick

@ZloyNick ZloyNick commented May 4, 2020

Copy link
Copy Markdown

This commit adds 2 get|set methods:
Player::getSaturation();
Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.

This commit adds 2 get|set methods:
    Player::getSaturation();
    Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.
@yoraze

yoraze commented May 4, 2020

Copy link
Copy Markdown

#926 (comment)

@RandomClone

Copy link
Copy Markdown

You made a typo in line 2888

@ImDaRealAni

ImDaRealAni commented May 4, 2020

Copy link
Copy Markdown

#926 (comment)
Hydreon never merges public PRs anymore.

@ZloyNick

ZloyNick commented May 5, 2020

Copy link
Copy Markdown
Author

You made a typo in line 2888

Fixed. Thanks.

@IceCruelStuff

Copy link
Copy Markdown

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

@ZloyNick

Copy link
Copy Markdown
Author

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

SteadFast2 haven't types declaration.

@dktapps

dktapps commented May 10, 2020

Copy link
Copy Markdown
Member

This PR is a waste of time as pointed out by myself in the comment linked above, which, you might notice, was given a 👍 by one of the Steadfast maintainers. So, it really makes no difference whether you apply those type hints or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants