Getter and setter addition for saturation. Enchanted golden apple works#963
Open
ZloyNick wants to merge 2 commits into
Open
Getter and setter addition for saturation. Enchanted golden apple works#963ZloyNick wants to merge 2 commits into
ZloyNick wants to merge 2 commits into
Conversation
This commit adds 2 get|set methods:
Player::getSaturation();
Player::setSaturation($val);
and makes Enchanted Golden Apples are workable.
|
You made a typo in line 2888 |
|
#926 (comment) |
Author
Fixed. Thanks. |
|
Maybe you should use |
Author
SteadFast2 haven't types declaration. |
Member
|
This PR is a waste of time as pointed out by myself in the comment linked above, which, you might notice, was given a 👍 by one of the Steadfast maintainers. So, it really makes no difference whether you apply those type hints or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds 2 get|set methods:
Player::getSaturation();
Player::setSaturation($val);
and makes Enchanted Golden Apples are workable.