Skip to content

Add support for PureChat plugin#757

Open
Saxavlax001 wants to merge 1 commit into
Hydreon:masterfrom
Saxavlax001:fix-for-purechat
Open

Add support for PureChat plugin#757
Saxavlax001 wants to merge 1 commit into
Hydreon:masterfrom
Saxavlax001:fix-for-purechat

Conversation

@Saxavlax001

@Saxavlax001 Saxavlax001 commented Jan 22, 2019

Copy link
Copy Markdown

After some minutes-hours,I found the correct code that makes PureChat plugin work with steadfast2.No errors found and it's working.Please accept that pr,and also polish words removed automatically I don't know why,but anyway, accept that pr, it's useful and it works.

@enricoangelon

Copy link
Copy Markdown

This will never work... is just copy paste from pocketmine

@Saxavlax001

Copy link
Copy Markdown
Author

What do you mean?I had tested it before I do the pull request and works fine.

@Saxavlax001

Copy link
Copy Markdown
Author

But anyway no one is going to accept it,so I'll continue having it on my fork.

@IceCruelStuff

Copy link
Copy Markdown

This will not work.

@Saxavlax001

Saxavlax001 commented Mar 1, 2020

Copy link
Copy Markdown
Author

Ok say whatever you want,I don't know if pull request is outdated now,but this change works for me.It may not work now only on this pull request.

@Saxavlax001

Copy link
Copy Markdown
Author

Also because something is copy paste,that doesn't mean that it won't work.

@lukeeey

lukeeey commented Mar 18, 2020

Copy link
Copy Markdown

@Saxavlax001 If you know anything about PHP, you will know that it is not possible for this to work. All you did was move a function call that broadcasts a message outside the scope where the $ev variable was available. This code will not work, i am telling you this now, don't argue it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants