Skip to content

lock down pipelines #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JFriel merged 2 commits into from
Mar 12, 2025
Merged

lock down pipelines #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8888780
lock down pipelines
JFriel Mar 11, 2025
b989683
fix typo
JFriel Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [8.4.4] - Ureleased

- Re-add AggregateGraph functionality
- Add ability to show/hide quick edit pipeline controls during extractions

## [8.4.3] - 2025-02-24

Expand Down
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="NPOI" Version="2.7.2" />
<PackageVersion Include="NLog" Version="5.4.0" />
<PackageVersion Include="SixLabors.ImageSharp" Version="3.1.6" />
<PackageVersion Include="SixLabors.ImageSharp" Version="3.1.7" />
<PackageVersion Include="SixLabors.ImageSharp.Drawing" Version="2.1.5" />
<PackageVersion Include="Spectre.Console" Version="0.49.1" />
<PackageVersion Include="SSH.NET" Version="2024.2.0" />
Expand All @@ -45,4 +45,4 @@
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
</ItemGroup>
</Project>
</Project>
7 changes: 7 additions & 0 deletions Rdmp.UI/PipelineUIs/Pipelines/PipelineSelectionUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
using Rdmp.Core.DataExport.Data;
using Rdmp.Core.Repositories;
using Rdmp.Core.ReusableLibraryCode.Annotations;
using Rdmp.Core.Setting;
using Rdmp.UI.ItemActivation;

namespace Rdmp.UI.PipelineUIs.Pipelines;
Expand Down Expand Up @@ -130,6 +131,12 @@ public PipelineSelectionUI(IActivateItems activator, IPipelineUseCase useCase, I

ddPipelines.DrawMode = DrawMode.OwnerDrawFixed;
ddPipelines.DrawItem += cmb_Type_DrawItem;
var showButtonsSetting = activator.RepositoryLocator.CatalogueRepository.GetAllObjects<Setting>().FirstOrDefault(static s => s.Key == "ExtractionPipelineQuickEdit");
var showbuttons = showButtonsSetting != null && Convert.ToBoolean(showButtonsSetting.Value);
btnClonePipeline.Visible = showbuttons;
btnCreateNewPipeline.Visible = showbuttons;
btnDeletePipeline.Visible = showbuttons;
btnEditPipeline.Visible = showbuttons;
}

private void cmb_Type_DrawItem(object sender, DrawItemEventArgs e)
Expand Down
13 changes: 13 additions & 0 deletions Rdmp.UI/SimpleDialogs/InstanceSettings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Rdmp.UI/SimpleDialogs/InstanceSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public InstanceSettings(IActivateItems activator)
RegisterCheckbox(cbAutoSuggestProjectNumbers, "AutoSuggestProjectNumbers");
RegisterCheckbox(cbCohortVersioningOnCommit, "PromptForVersionOnCohortCommit");
RegisterCheckbox(cbYesNoAll, "ToggleYestoAllNotoAlldataloadcheck");
RegisterCheckbox(cbExtractionPipelineQuickEdit, "ExtractionPipelineQuickEdit");
_loaded = true;
}

Expand Down