Adjust some nullpo checks#3378
Open
MrKeiKun wants to merge 1 commit into
Open
Conversation
MrKeiKun
changed the title
MrKeiKun
force-pushed
the
fix-2973-nullpo-checks
branch
from
49350d4 to
f4dbee7
Compare
hemagx
requested changes
May 24, 2026
In pc_authok, pc_setpos is called to warp the player to their last saved position before status_calc_pc(SCO_FIRST) runs in pc_reg_received. Since pc_setpos triggers status_calc_regen, and SCO_FIRST is the only place that initializes sd->regen.skill and sd->regen.sitting, those pointers were NULL on the first regen calculation, causing a nullpo crash. Initializing both pointers in pc_authok before the pc_setpos call fixes the root cause. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix-2973-nullpo-checks
branch
from
f4dbee7 to
314f104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Adjust some nullpo check on status_calc_regen_pc and status_calc_regen_rate_pc
Issues addressed:
#2973
#2847 (probably?)