fix(prompts): substitute template variables with falsy values (0, false, "")#5714
Open
devteamaegis wants to merge 1 commit into
Open
fix(prompts): substitute template variables with falsy values (0, false, "")#5714devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
…se, empty string)
|
@devteamaegis is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
HeliconeTemplateManager.substituteVariablesleft the raw{{hc:NAME:type}}placeholder in the rendered prompt whenever an input value was falsy (0,false, or""), so those literals were sent to the LLM instead of the real value.Why it happens
The replacement callback used
value ? String(value) : match, which treats0/false/""as "missing". The JSON substitution path (performRegexReplacement) already guards withvalue !== undefined && value !== null; the string path didn't.Fix
One line in
packages/prompts/templates.ts— switch the truthiness check to an explicitundefined/nullcheck, matching the JSON path. Missing variables (genuinelyundefined) still leave the placeholder untouched.Test
Added
packages/__tests__/prompts/templates.test.ts. Fails before the change (placeholder leaks forcount: 0), passes after. Truthy values and missing-variable behavior unchanged.