Honor Retry-After for provider rate limits#5687
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry-Afterheaders from provider 429 responsesRetry-Afteras the minimum retry delay while keeping exponential backoff as the fallbackWhy
Provider 429s are different from 5xx failures: when a provider sends
Retry-After, retrying inside that cooldown window just burns attempts and can amplify rate-limit pressure. This makes the gateway observe and respect the provider's rate-limit signal instead of treating 429 exactly like transient 5xx responses.Fixes #5672.
Tests
yarn workspace helicone-api test:jawn --runTestsByPath src/lib/proxy/__tests__/ProviderClient.test.tsyarn workspace helicone-api build