Skip to content

fix(web): prevent memory leak in onboarding interval cleanup #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): prevent memory leak in onboarding interval cleanup #5671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions web/components/layout/onboardingContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
useCallback,
useContext,
useEffect,
useRef,
useState,
} from "react";
import { OnboardingPopoverAccordion } from "../templates/onboarding/OnboardingPopoverMore";
Expand Down Expand Up @@ -424,6 +425,7 @@ export const OnboardingProvider = ({
const [isOnboardingVisible, setIsOnboardingVisible] = useState(false);
const [onClickElement, setOnClickElement] = useState<() => void>(() => {});
const [isOnboardingComplete, setIsOnboardingComplete] = useState(false);
const onboardingIntervalRef = useRef<ReturnType<typeof setInterval> | null>(null);
const setCurrentStep = useCallback((step: number, delayMs?: number) => {
if (delayMs) {
setTimeout(() => {
Expand All @@ -437,6 +439,10 @@ export const OnboardingProvider = ({

const startOnboarding = useCallback(() => {
if (isOnboardingVisible) return;
// Clear any existing interval before starting a new one
if (onboardingIntervalRef.current) {
clearInterval(onboardingIntervalRef.current);
}
const setReady = async () => {
const countResponse = await $JAWN_API.POST("/v1/request/count/query", {
body: {
Expand All @@ -445,17 +451,28 @@ export const OnboardingProvider = ({
});

if (countResponse?.data?.data && countResponse.data.data > 6) {
clearInterval(interval);
if (onboardingIntervalRef.current) {
clearInterval(onboardingIntervalRef.current);
onboardingIntervalRef.current = null;
}
setIsOnboardingVisible(true);
setCurrentStep(0);
router.push("/requests");
}
};

const interval = setInterval(setReady, 1000);
return () => clearInterval(interval);
onboardingIntervalRef.current = setInterval(setReady, 1000);
}, [setCurrentStep, isOnboardingVisible, router]);

// Cleanup interval on unmount
useEffect(() => {
return () => {
if (onboardingIntervalRef.current) {
clearInterval(onboardingIntervalRef.current);
}
};
}, []);

const endOnboarding = useCallback(() => {
setCurrentStep(0);
setIsOnboardingVisible(false);
Expand Down