Skip to content

Sort history by recency. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacoblurye wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sort history by recency. #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6238920
Sort history by recency.
Dec 6, 2017
1ebda74
Add error-checking.
Dec 6, 2017
38b0f7a
Added `null` checking
nickboucher Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions views/profile.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,21 @@

function buildLeaderboard(leaders) {
var start = '<div id="leaderboard-table">'
var tHead = '<div class="row header-row">' +
'<div class="col-md-3">Friend</div>' +
'<div class="col-md-2">Empathetic</div>' +
'<div class="col-md-2">Polite</div>' +
'<div class="col-md-3">Knowledgeable</div>' +
'<div class="col-md-2">Creative</div>' +
var tHead = '<div class="row header-row">' +
'<div class="col-md-3">Friend</div>' +
'<div class="col-md-2">Empathetic</div>' +
'<div class="col-md-2">Polite</div>' +
'<div class="col-md-3">Knowledgeable</div>' +
'<div class="col-md-2">Creative</div>' +
'</div>';
var cols = '';
leaders.forEach(friend => {
var friendStats = ('<div class="row data-row">' +
'<div class="col-md-3">' + friend.name + '</div>' +
'<div class="col-md-2">' + countBadges('empathetic' , friend) + '</div>' +
'<div class="col-md-3">' + friend.name + '</div>' +
'<div class="col-md-2">' + countBadges('empathetic' , friend) + '</div>' +
'<div class="col-md-2">' + countBadges('polite' , friend) + '</div>' +
'<div class="col-md-3">' + countBadges('knowledgeable', friend) + '</div>' +
'<div class="col-md-2">' + countBadges('creative' , friend) + '</div>' +
'<div class="col-md-3">' + countBadges('knowledgeable', friend) + '</div>' +
'<div class="col-md-2">' + countBadges('creative' , friend) + '</div>' +
'</div>');
cols += friendStats;
});
Expand Down Expand Up @@ -226,6 +226,19 @@
$("#convo-count").text(res.length);
}

// Sort the results by recency
res.sort((a, b) => {
a_info = extraInfoFromChat(a);
b_info = extraInfoFromChat(b);

if (a_info === undefined || b_info === undefined
|| a_info === null || b_info === null) {
return 0
}

return a_info.connectedDate - b_info.connectedDate;
}).reverse()

// Populate history form

res.forEach(row => {
Expand Down Expand Up @@ -335,7 +348,7 @@
$("#convo-button").on("click", (e) => {
// This is a hack, see questions code for this onclick function.
// Needed to do this so we could use function internal to questions.handlebars' script.
$('#call')[0].onclick();
$('#call')[0].onclick();
});

getHistory();
Expand Down