-
Notifications
You must be signed in to change notification settings - Fork 725
Adult Crawlspaces Cheat #6623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unreference
wants to merge
4
commits into
HarbourMasters:develop
Choose a base branch
from
unreference:feat/adult-crawlspaces
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−3
Open
Adult Crawlspaces Cheat #6623
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
71f5ef5
feat(enhancement): Adult Link crawlspaces cheat
unreference ca1d398
Update soh/src/overlays/actors/ovl_player_actor/z_player.c
unreference 5adbce7
feat(enhancement): Prefer VB hook over inline CVar
unreference 6f0bf5a
chore: Remove unnecessary include
unreference File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #include "soh/Enhancements/game-interactor/GameInteractor.h" | ||
| #include "soh/ShipInit.hpp" | ||
|
|
||
| #define CVAR_ADULT_CRAWLSPACES_NAME CVAR_CHEAT("AdultCrawlspaces") | ||
| #define CVAR_ADULT_CRAWLSPACES_VALUE CVarGetInteger(CVAR_ADULT_CRAWLSPACES_NAME, 0) | ||
|
|
||
| void RegisterAdultCrawlspaces() { | ||
| COND_VB_SHOULD(VB_LINK_BE_ABLE_TO_ENTER_CRAWLSPACE, CVAR_ADULT_CRAWLSPACES_VALUE, { *should = true; }); | ||
| } | ||
|
|
||
| static RegisterShipInitFunc initFunc(RegisterAdultCrawlspaces, { CVAR_ADULT_CRAWLSPACES_NAME }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these VBs be combined?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that as well, but I decided to keep them separate because they handle different conditions.
VB_CRAWLis the same pattern asVB_OPEN_CHEST-- it's the randomizer shuffle gate (RAND_INF_CAN_CRAWL).VB_LINK_BE_ABLE_TO_ENTER_CRAWLSPACEwraps the age check which crawlspaces have, but chests don't. Keeping them separate means that the cheat can let Adult Link through without bypassing a possible future shuffle restriction.That said, I don't imagine that ever actually being a randomization option simply because there aren't a lot of crawlspaces to begin with, so I think either works.