Skip to content

feat: 검색 페이지에 대한 디자인 시스템 적용#179

Merged
MTtankkeo merged 2 commits into
mainfrom
search
Jun 25, 2026
Merged

feat: 검색 페이지에 대한 디자인 시스템 적용#179
MTtankkeo merged 2 commits into
mainfrom
search

Conversation

@MTtankkeo

Copy link
Copy Markdown
Member

변경 사항

  • 검색 페이지 전반에 GDS 디자인 시스템을 적용
  • 검색 결과 화면의 공통 UI 관련 로직 정리
  • 검색 전/결과 없음 상태를 SearchWelcomeState, SearchEmptyState로 분리
  • 피드/유저/게시글 검색 결과 리스트의 여백, 반응형 레이아웃, 빈 상태 처리 정리
  • 게시글 목록 UI를 GrimityPostView로 공통화하여 게시판/검색 페이지에서 재사용
  • 게시글 검색 결과에 북마크 표시 및 저장/해제 동작 추가

피그마 참고

@MTtankkeo MTtankkeo requested a review from aiden30015 June 24, 2026 21:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several enums to simplify JSON serialization and migrates the board and search views to use GDS (Grimity Design System) components, including the introduction of GrimityPostView and GdsUserCard. It also adds bookmarking capabilities to post cards and refactors search tab views to handle empty and welcome states. The review feedback highlights critical compilation errors in the search tag views due to incorrect scroll direction types, a JSON serialization mismatch in the PostType enum, and a UX regression in BoardView where a missing scroll controller prevents scrolling to the top on page changes. Additionally, minor issues regarding unsupported sort options and incorrect button labels in the search user tab were identified.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/search/view/search_recommend_tag_view.dart
Comment thread lib/presentation/search/widget/search_recommand_tag_bar.dart
Comment thread lib/app/enum/post_type.enum.dart Outdated
Comment thread lib/presentation/search/widget/search_tab_bar.dart Outdated
Comment thread lib/presentation/search/view/search_user_tab_view.dart
Comment thread lib/presentation/board/view/board_view.dart
@MTtankkeo MTtankkeo merged commit c02e165 into main Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant