Reference System.Runtime.CompilerServices.Unsafe directly in every library project#560
Open
StephenCWills wants to merge 3 commits into
Open
Reference System.Runtime.CompilerServices.Unsafe directly in every library project#560StephenCWills wants to merge 3 commits into
StephenCWills wants to merge 3 commits into
Conversation
StephenCWills
force-pushed
the
no-transitive-references
branch
from
6b665fe to
7a4458c
Compare
StephenCWills
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the build server, projects with transitive references to this dll would copy the file from either
C:\Program Files\IIS\Microsoft Web Deploy V3orC:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\PublicAssembliesinstead ofSource\Dependencies\NuGet. This would cause theBuild\Output\Release\Librariesfolder to have the wrong version of the assembly. Directly referencing the assembly should force the build to get the file out of the NuGet folder.