Repository navigation
fix(mobile and desktop): prevent horizontal clipping of transaction history - #1843
Open
kwasiasomani wants to merge 1 commit into
Open
kwasiasomani wants to merge 1 commit into
kwasiasomani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On mobile the wallet names in the transaction history were cut off on the right
edge with no way to reach the hidden text.
The timeline rows are flex containers, and flex items default to
min-width: autoso they can't shrink below their content width. On a narrow screen the wallet name
had less space than it needed, so it overflowed and got clipped by the drawer.
Fixed by adding
minWidth: 0so the containers can shrink,overflowWrapso longnames wrap instead of forcing the row wider, and making the date column and font
size responsive to free up space. Desktop is unchanged.
Fixes #1842
How has this been tested?
npm run lint— 0 errorsnpm run build— compiles successfullyType of change
Screenshots