Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Visiting a wallet URL with a non-existent wallet ID was showing a 500 error page instead of a 404.
Debugging: Confirmed via direct API call that the backend returns HTTP 404 for non-existent wallet IDs. The existing
wrapperutility inutils.jsalready convertse.response?.status === 404to{ notFound: true }for Next.js. However, the 404 error fromgetWalletByIdwas not reliably reaching the wrapper with itsresponseproperty intact.Fix: Added an explicit try-catch in
serverSideDatathat catches only HTTP 404 errors fromgetWalletByIdand re-throws them cleanly so the wrapper receives a properly structured error and returns{ notFound: true }. All other errors (real server errors, network failures) are re-thrown unchanged so they continue to be handled as transient failures.Fixes #1546
Type of change
Screenshots
How Has This Been Tested?
Manually tested on local dev server and confirmed the 404 page renders correctly instead of a 500 error.
Checklist: