Repository navigation
test: Cypress regression and cache-header tests for ISR changes - #1826
Merged
arnoldcastro5000 merged 6 commits intoJun 10, 2026
Merged
arnoldcastro5000 merged 6 commits into
arnoldcastro5000 merged 6 commits into
Conversation
- Set isrMemoryCacheSize: 0 to eliminate LRU bug exposure and reduce memory overhead - memory request: 1300Mi, limit: 1792Mi (based on observed ~1266Mi steady-state) - NODE_OPTIONS --max-old-space-size=1344 (75% of limit) - cpu request: 50m, limit: 200m
Collaborator
Author
|
The full sequence:
|
…esource-limits' into test/combined-prs
…terval' into test/combined-prs
5 of 11 tasks
dadiorchen
reviewed
Jun 6, 2026
dadiorchen
left a comment
dadiorchen
left a comment
Collaborator
There was a problem hiding this comment.
This type of test is fine but it is difficult to maintain in the future, it is not easy for people to understand and fix problem if there were
Collaborator
Author
Collaborator
Author
|
🎉 This PR is included in version 2.9.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cypress/tests/integration/isr-regression.cy.js— verifies all 6 ISR pages render correctly afterisrMemoryCacheSize:0(PR fix: disable ISR memory cache; set prod resource limits #1824)cypress/tests/e2e/isr-cache-headers.cy.js— assertsCache-Control: s-maxage=300and disk cache hit on second request (PR fix: increase ISR revalidation interval from 30s to 300s on content p… #1825)v2/capturestest is skipped pending a fixture; all other specs passTest plan
npm run cypress:run:fast— all integration specs pass (13 pass, 1 skip)npm run build && npm run start, thencypress run --spec cypress/tests/e2e/isr-cache-headers.cy.jsDepends on #1824 and #1825.