Repository navigation
fix(wallet-api): stop transaction.id from clobbering token.id - #606
Merged
dadiorchen merged 1 commit intoOct 1, 2026
Merged
Conversation
Tokens in a transfer came back with the transaction row's id, because token and transaction both have an id column and an unqualified select across the join let the joined table win. Every token link on a transfer was dead, and the accept message named a token that did not exist. Selecting token.* returns the real ids. This re-applies Greenstand#564, which the rollback in Greenstand#593 reverted. Closes Greenstand/treetracker-wallet-app#853
dadiorchen
approved these changes
Oct 1, 2026
|
🎉 This PR is included in version 1.44.0-keycloak.41 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Greenstand/treetracker-wallet-app#853
Problem
Tokens in a transfer came back with the transaction row's id.
tokenandtransactionboth have anidcolumn, and an unqualifiedselect('*')across the join let the joined table win. Every token link on a transfer was dead, andthe accept message named a token that did not exist.
Change
select('token.*'). One word.This re-applies #564, which the rollback in #593 reverted.
Verification