Repository navigation
fix(action-token): let a claim name the wallet that receives - #605
Merged
Merged
Conversation
The app sends the wallet on every claim, and the schema stopped accepting it, so Joi rejected the request and every claim answered 422 "wallet is not allowed". Redeem accepts it again and checks it with canActFor: the account id first, falling back to a manage trust for wallets that carry no keycloak id. Absent the field, the login wallet still receives, as before. This is also what the app needs to honour the wallet a visitor just created to claim into, which was the original report. Closes Greenstand/treetracker-wallet-app#855
|
🎉 This PR is included in version 1.44.0-keycloak.40 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Greenstand/treetracker-wallet-app#855
Problem
The app sends the wallet on every claim, and the schema stopped accepting it, so every claim answered
422 "wallet" is not allowed. Claiming a share link is broken outright, not just routed to the wrong wallet.Change
Redeem accepts
walletagain and checks it withcanActFor: the account id first, falling back to a manage trust for wallets that carry no keycloak id. Absent the field, the login wallet still receives, as before.Same shape as #596 on the generate side.
Also unblocks
Greenstand/treetracker-wallet-app#896, which lets a claimer choose the destination wallet and cannot work without this field.
Verification