Repository navigation
fix(keycloak): keep the web-map banner off the submit button - #335
Merged
mahdi2ba merged 1 commit intoOct 12, 2026
Merged
Conversation
js/treetracker.js pins the web-map banner to the bottom of the viewport. On a short screen the registration form cannot scroll far enough to clear it, so the banner covers Register and a tap lands on the banner's link instead of the button. Pad the form by more than the banner's footprint so the button is always reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Greenstand/treetracker-wallet-app#906.
Problem
login/resources/js/treetracker.jsappends the web-map banner withposition: fixed; bottom: 0. On a short screen the registration form cannot scroll far enough to clear it, so the banner sits on top of Register.It is not just visual.
document.elementFromPointat the button's centre returns the banner's<a>, so the tap opens the web map instead of submitting.The reporter hit this on the wallet app, but the theme is shared, so every Keycloak page is exposed. Registration is simply the tallest.
Change
Pad
#kc-contentby 90px, more than the banner's measured 73px footprint (63px tall plus its 10px margin).Verified
Keycloak 23 locally with this theme mounted, measured at full scroll:
AINPUTAINPUT value=RegisterINPUT value=Sign InConfirmed after a container restart serving the file itself, not a devtools injection.