Repository navigation
fix(keycloak): keep register button clear of background banner on small screensPatch 1 - #334
Open
MuKuNdSaNjAy wants to merge 2 commits into
Open
MuKuNdSaNjAy wants to merge 2 commits into
MuKuNdSaNjAy wants to merge 2 commits into
Conversation
fix/905-register-banner-overlap
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Greenstand/treetracker-wallet-app#905
Problem
The "Find the tree on the background on our web map" banner is injected by
login/resources/js/treetracker.jswith inlineposition: fixed; bottom: 0. On short viewports (e.g. 408×692) it overlays the Register button.Changes
treetracker.js: replaced inline styles with att-bg-creditclass; addedrel="noopener noreferrer"to the link.treetracker.css: added.tt-bg-credit(same styles as before) and a media query (max-width: 767px,max-height: 800px) that switches it toposition: staticso it flows below the form.Desktop layout is unchanged.
Testing
Verified on the live register page (prod-k8s.treetracker.org) via DevTools at 408×692 and desktop width. The banner now sits below the form on small screens, and the Register button is fully visible.
Note
The console also shows two theme stylesheets refused due to an empty MIME type (likely the
web_modules/...entries intheme.properties). That's out of scope here, but it may need a separate issue.