Repository navigation
feat(wallets): add a wallet list for wallet-admin users - #1240
Conversation
|
@samwel141 did you run the BDD and pass? Please make sure BDD passes for this feature. Also, run bdd test/report to generate new report and video, and push them up, for this repo, we manually upload BDD video and we will avoid this in the future. |
|
@dadiorchen But now it is 5,113 files and GitHub cannot compute the diff, so the Files tab shows nothing and the code can only be reviewed by pulling locally. Keep it that way, or move the BDD into its own PR? |
|
@samwel141 can you double check the video recorded the new feature? I can not find it in the run.mp4 test-run.mp4 |
Implements features/wallet/admin.feature: a Wallets menu item visible to the wallet-admin role, opening a list of every wallet. Menu items and routes are the same array, so one entry in getRoutes gives both, gated the same way every other entry is. The view follows OrganizationsView: react-query, a table that falls back to cards on small screens, debounced search and pagination. Reads GET /admin/wallets on the keycloak build of the wallet-api, through a new REACT_APP_WALLET_API_ROOT. v2 is not usable here: it sits behind an API key, which a browser app cannot hold without publishing it, and its wallet listing is scoped to the caller's own wallet rather than to every wallet. BDD: adds the one missing step and its page object. The scenario stays skipped because dev has no wallet-admin account yet; set BDD_WALLET_ADMIN_USERNAME and BDD_WALLET_ADMIN_PASSWORD and drop the tag to run it. Closes Greenstand#1239
Removes @Skip from features/wallet/admin.feature and adds the dev bdd-wallet-admin account alongside the other roles. The wallet list step waited on the container, which is on screen while the request is still in flight, so it would have passed on an empty or failing list. It now waits for the wallets themselves. 6 steps passing against dev. The video is at reports/video/wallet-admin/run.mp4 and ends on the loaded wallet table. Needs Greenstand#1245 to record correctly, without which the video shows whichever feature ran last.
89ceab9 to
5c91929
Compare
|
@dadiorchen Fixed in #1245: videos now go to Re-ran on top of that. The video is at |
Closes #1239
Adds a Wallets page to the admin panel: a menu item visible to the
wallet-adminrole, opening a list of every wallet with search, sort and pagination. This satisfies the scenario infeatures/wallet/admin.feature.Change
getRoutes, which is both the menu item and the route, gated like every other entry.WalletsViewfollowsOrganizationsView: react-query, a table that falls back to cards on small screens, debounced search, pagination.REACT_APP_WALLET_API_ROOTpointing at the keycloak build of the wallet-api.Depends on
GET /admin/wallets. Do not merge before that one.Verification
WalletsViewtests.npm run lintclean,npm run build:devsucceeds.features/wallet/admin.featureun-skipped and passing, 6 steps against the devbdd-wallet-adminaccount. Report and video committed.