test: add tests for zero sized realloc(3)#255
Open
cgzones wants to merge 1 commit intoGrapheneOS:mainfrom
Open
test: add tests for zero sized realloc(3)#255cgzones wants to merge 1 commit intoGrapheneOS:mainfrom
cgzones wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
Member
|
This will break real world applications and isn't actually memory corruption, resulting in reduced security from not being able to use those applications from hardened_malloc. |
Member
|
The safest way to handle this is the way it already does: treating it the same way as malloc(0) by resizing to a 0 size allocation, which with hardened_malloc points to PROT_NONE memory with a unique address meeting the minimum alignment requirements for malloc despite it having a usable size of 0. |
C23 declared calling realloc(3) with a non-NULL pointer and zero size Undefined behavior. Check that hardened_malloc handles that case sanely by free'ing the old pointer and returning a special pointer, like `malloc(3)` called with size zero.
Contributor
Author
|
Dropped the change in behavior, and added some additional test cases. |
cgzones
changed the title
Contributor
Author
|
Kindly ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C23 declared calling realloc(3) with a non-NULL pointer and zero size Undefined behavior.
Check that hardened_malloc handles that case sanely by free'ing the old pointer and returning a special pointer, like
malloc(3)called with size zero.