Skip to content

chore: Migrate gsutil usage to gcloud storage #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 1 commit into from
Apr 7, 2026
+6 −6
Merged

chore: Migrate gsutil usage to gcloud storage #4493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jib-cli/scripts/update_gcs_latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ versionString="{\"latest\":\"$1\"}"
destination="gs://jib-versions/jib-cli"

echo $versionString > jib-cli-temp
gsutil cp jib-cli-temp $destination
gsutil acl ch -u allUsers:READ $destination
gcloud storage cp jib-cli-temp $destination
gcloud storage objects update --add-acl-grant=allUsers=READ $destination
Comment on lines +31 to +32
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better efficiency and atomicity, you can combine the copy and ACL update into a single command by using the --predefined-acl=public-read flag. This avoids a second API call to update the object's ACLs after it has been uploaded.

Suggested change
gcloud storage cp jib-cli-temp $destination
gcloud storage objects update --add-acl-grant=allUsers=READ $destination
gcloud storage cp --predefined-acl=public-read jib-cli-temp $destination

rm jib-cli-temp

gcsResult=$(curl https://storage.googleapis.com/jib-versions/jib-cli)
Expand Down
4 changes: 2 additions & 2 deletions jib-gradle-plugin/scripts/update_gcs_latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ versionString="{\"latest\":\"$1\"}"
destination="gs://jib-versions/jib-gradle"

echo $versionString > jib-gradle
gsutil cp jib-gradle $destination
gsutil acl ch -u allUsers:READ $destination
gcloud storage cp jib-gradle $destination
gcloud storage objects update --add-acl-grant=allUsers:READ $destination
Comment on lines +31 to +32
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better efficiency and atomicity, you can combine the copy and ACL update into a single command by using the --predefined-acl=public-read flag. This avoids a second API call to update the object's ACLs after it has been uploaded.

Suggested change
gcloud storage cp jib-gradle $destination
gcloud storage objects update --add-acl-grant=allUsers:READ $destination
gcloud storage cp --predefined-acl=public-read jib-gradle $destination

rm jib-gradle

gcsResult=$(curl https://storage.googleapis.com/jib-versions/jib-gradle)
Expand Down
4 changes: 2 additions & 2 deletions jib-maven-plugin/scripts/update_gcs_latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ versionString="{\"latest\":\"$1\"}"
destination="gs://jib-versions/jib-maven"

echo $versionString > jib-maven
gsutil cp jib-maven $destination
gsutil acl ch -u allUsers:READ $destination
gcloud storage cp jib-maven $destination
gcloud storage objects update --add-acl-grant=allUsers:READ $destination
Comment on lines +31 to +32
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better efficiency and atomicity, you can combine the copy and ACL update into a single command by using the --predefined-acl=public-read flag. This avoids a second API call to update the object's ACLs after it has been uploaded.

Suggested change
gcloud storage cp jib-maven $destination
gcloud storage objects update --add-acl-grant=allUsers:READ $destination
gcloud storage cp --predefined-acl=public-read jib-maven $destination

rm jib-maven

gcsResult=$(curl https://storage.googleapis.com/jib-versions/jib-maven)
Expand Down
Loading