feat(v2): add support for build_config arguments#398
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I believe this closes #397. |
Hello @trshafer |
|
/assign maemayve |
|
/gcbrun |
|
The change looks good to me but the description seems incorrect. The build_config block will not actually kick off a build. The only way to start a build is to use Cloud Run Functions. The build_config block was added to support dual edit between Cloud Run service resources and the Cloud Run Function that generated these services. More information about how the field is used is documented in the Cloud Run Functions Terraform Tutorial |
Hey @maemayve |
|
build_config is adding a lot of confusion for customers., please do not merge |
Removing the approval based on feedback from Steren
613c105 to
82be4b0
Compare
|
/gcbrun |
b59015f to
c17f2d9
Compare
|
/gcbrun |
This PR adds support for the build_config block to the Cloud Run v2 module, enabling users to build container images from source using Cloud Build instead of pre-built container images.
✨ What's New
✅ New input variable: build_config — optional object block for Cloud Build configuration
✅ Dynamic block: Adds build_config block inside google_cloud_run_v2_service.main
✅ Output: Adds build_name output to expose Cloud Build job name (output-only)
✅ README update: Includes usage example for build_config