Skip to content

feat(v2): add support for build_config arguments#398

Open
PawanSenapati wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
PawanSenapati:ft/build_config
Open

feat(v2): add support for build_config arguments#398
PawanSenapati wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
PawanSenapati:ft/build_config

Conversation

@PawanSenapati
Copy link
Copy Markdown

This PR adds support for the build_config block to the Cloud Run v2 module, enabling users to build container images from source using Cloud Build instead of pre-built container images.

✨ What's New

✅ New input variable: build_config — optional object block for Cloud Build configuration
✅ Dynamic block: Adds build_config block inside google_cloud_run_v2_service.main
✅ Output: Adds build_name output to expose Cloud Build job name (output-only)
✅ README update: Includes usage example for build_config

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@trshafer
Copy link
Copy Markdown

I believe this closes #397.

@PawanSenapati
Copy link
Copy Markdown
Author

  • horized to push to this branch

Hello @trshafer
I am contributing for the first time. I am not sure if I have to do anything from my end. Could you please help me?

@PawanSenapati PawanSenapati requested review from a team as code owners September 19, 2025 20:36
@trshafer
Copy link
Copy Markdown

/assign maemayve

@trshafer
Copy link
Copy Markdown

/gcbrun

@maemayve
Copy link
Copy Markdown

maemayve commented Sep 24, 2025

The change looks good to me but the description seems incorrect. The build_config block will not actually kick off a build. The only way to start a build is to use Cloud Run Functions. The build_config block was added to support dual edit between Cloud Run service resources and the Cloud Run Function that generated these services.

More information about how the field is used is documented in the Cloud Run Functions Terraform Tutorial

maemayve
maemayve previously approved these changes Sep 24, 2025
@PawanSenapati
Copy link
Copy Markdown
Author

The change looks good to me but the description seems incorrect. The build_config block will not actually kick off a build. The only way to start a build is to use Cloud Run Functions. The build_config block was added to support dual edit between Cloud Run service resources and the Cloud Run Function that generated these services.

More information about how the field is used is documented in the Cloud Run Functions Terraform Tutorial

Hey @maemayve
Thank you for the clarification. I have modified the description. Could you please re-run the workflows?

@maemayve maemayve enabled auto-merge (squash) October 9, 2025 22:07
@steren
Copy link
Copy Markdown

steren commented Dec 1, 2025

build_config is adding a lot of confusion for customers., please do not merge

@maemayve maemayve disabled auto-merge December 1, 2025 22:26
@maemayve maemayve dismissed their stale review December 1, 2025 22:27

Removing the approval based on feedback from Steren

@amandakarina
Copy link
Copy Markdown
Collaborator

/gcbrun

marcelorobj pushed a commit to marcelorobj/terraform-google-cloud-run that referenced this pull request Feb 3, 2026
@q2w q2w requested a review from krprabhat-eng as a code owner February 17, 2026 05:35
@amandakarina
Copy link
Copy Markdown
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants