Skip to content

Simplify path generation - #1698

Merged
rfbgo merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:simplify-repo
Aug 3, 2026
Merged

Simplify path generation#1698
rfbgo merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:simplify-repo

Conversation

@linsword13

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors lib/ramble/ramble/repository.py by removing redundant, boilerplate helper functions and replacing the hardcoded paths dictionary with a dynamically generated dictionary using a dictionary comprehension over ObjectTypes and functools.partial. This significantly reduces code duplication and improves maintainability. There are no review comments to address, and I have no additional feedback to provide.

@ramble-pr-bot

ramble-pr-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 79e3aee

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.1198 2.0864 (98c396b) 2.1804
test_large_template_expansion passed 1.4042 1.4189 (98c396b) 1.5007
test_many_experiments passed 24.5766 24.7397 (98c396b) 25.6821
test_many_objects_defaults passed 14.2836 14.7790 (98c396b) 15.2573
test_matrix_filter_perf passed 0.9028 0.8987 (98c396b) 0.9282

@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (98c396b) to head (79e3aee).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1698      +/-   ##
===========================================
- Coverage    93.35%   93.34%   -0.01%     
===========================================
  Files          365      365              
  Lines        35552    35522      -30     
===========================================
- Hits         33188    33158      -30     
  Misses        2364     2364              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfbgo
rfbgo merged commit 107cead into GoogleCloudPlatform:develop Aug 3, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants