Simplify path generation - #1698
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors lib/ramble/ramble/repository.py by removing redundant, boilerplate helper functions and replacing the hardcoded paths dictionary with a dynamically generated dictionary using a dictionary comprehension over ObjectTypes and functools.partial. This significantly reduces code duplication and improves maintainability. There are no review comments to address, and I have no additional feedback to provide.
Ramble Performance Test MetricsResults produced with commit: 79e3aee
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1698 +/- ##
===========================================
- Coverage 93.35% 93.34% -0.01%
===========================================
Files 365 365
Lines 35552 35522 -30
===========================================
- Hits 33188 33158 -30
Misses 2364 2364 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rfbgo
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.