fix complex awk parsing bug in command_variables [AI] - #1690
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies command execution in CommandVariable.extract_value by replacing manual command parsing and piping logic with subprocess.Popen(..., shell=True). It also adds a new test suite to verify pipeline escaping, logical chaining, and stderr redirection. The review feedback suggests handling potential UnicodeDecodeError exceptions by using errors="replace" when decoding stdout and stderr.
Ramble Performance Test MetricsResults produced with commit: c0b51a1
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1690 +/- ##
===========================================
+ Coverage 93.37% 93.44% +0.07%
===========================================
Files 368 369 +1
Lines 35570 35610 +40
===========================================
+ Hits 33214 33277 +63
+ Misses 2356 2333 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
I was initially suspicious this was truly functionally equivalent. After some back and forth with gemini I now think it's ready for review.