Skip to content

Add new simplify command - #1661

Draft
rfbgo wants to merge 9 commits into
GoogleCloudPlatform:developfrom
rfbgo:simplify
Draft

Add new simplify command#1661
rfbgo wants to merge 9 commits into
GoogleCloudPlatform:developfrom
rfbgo:simplify

Conversation

@rfbgo

@rfbgo rfbgo commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@rfbgo
rfbgo marked this pull request as draft July 16, 2026 17:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new simplify command for the Ramble framework, designed to identify and optionally remove unused variables, inputs, executables, and compilers from definition files, as well as detect broken references. The review feedback highlights several areas for improvement, including replacing broad exception handling with specific exceptions to improve debugging, optimizing the instantiation of the Keywords class to avoid redundant work, and refactoring duplicated cache-resetting logic in the test suite into a reusable helper function.

Comment thread lib/ramble/ramble/cmd/simplify.py Outdated
Comment thread lib/ramble/ramble/cmd/simplify.py
Comment thread lib/ramble/ramble/cmd/simplify.py Outdated
Comment thread lib/ramble/ramble/cmd/simplify.py Outdated
Comment thread lib/ramble/ramble/test/cmd/simplify.py Outdated
@ramble-pr-bot

ramble-pr-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: c30d974

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.1296 2.1432 (109e8d2) 2.7174
test_large_template_expansion passed 1.7176 1.4961 (109e8d2) 1.8272
test_many_experiments passed 30.6107 26.2705 (109e8d2) 31.1637
test_many_objects_defaults passed 19.3363 15.8682 (109e8d2) 19.2402
test_matrix_filter_perf passed 1.0376 1.0009 (109e8d2) 1.2124

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.92752% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.36%. Comparing base (109e8d2) to head (c30d974).

Files with missing lines Patch % Lines
lib/ramble/ramble/cmd/simplify.py 93.67% 38 Missing ⚠️
lib/ramble/ramble/test/cmd/simplify.py 94.28% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1661      +/-   ##
===========================================
+ Coverage    93.33%   93.36%   +0.03%     
===========================================
  Files          364      366       +2     
  Lines        35481    36502    +1021     
===========================================
+ Hits         33116    34080     +964     
- Misses        2365     2422      +57     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfbgo
rfbgo force-pushed the simplify branch 5 times, most recently from 7d03ee3 to 86ca51f Compare July 20, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant