Add (exclude_)where args to workload directive [AI] - #1642
Add (exclude_)where args to workload directive [AI]#1642douglasjacobsen wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces internal filters for workloads using where and exclude_where arguments, allowing experiments to be conditionally dropped during workspace setup. It updates the workload definition, experiment rendering logic, and documentation, and adds corresponding unit and end-to-end tests. A review comment points out an unused capsys fixture in the end-to-end tests that should be removed.
Ramble Performance Test MetricsResults produced with commit: 53a52d7
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1642 +/- ##
==========================================
Coverage ? 93.36%
==========================================
Files ? 366
Lines ? 35622
Branches ? 0
==========================================
Hits ? 33259
Misses ? 2363
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e594d56 to
a4a5fe4
Compare
| inputs=None, | ||
| tags=None, | ||
| where=None, | ||
| exclude_where=None, |
There was a problem hiding this comment.
Are we worried about the change in this arg order? This can technically be breaking for some people right? I think it should be rare, but if we know anyone who is likely to get broken we could provide backwards compat and depreciate warning?
There was a problem hiding this comment.
I don't know anyone who would currently break by this. Most people haven't adopted when yet (as it's not in main or a tag).
Technically, it is breaking, as when happens after the where arguments now. I only did it this way to make the interface consistent (as when is last in all of the rest of the interfaces). But I have pushed a changed to place the where args after when to avoid breaking other people's interfaces.
a4a5fe4 to
c0097db
Compare
This commit adds support for filtering experiments at the workload directive level. This can be used to silently reduce the possible experiment definitions, without creating errors. Tests and documentation are added as well.
c0097db to
53a52d7
Compare
2 participants
This merge adds support for filtering experiments at the workload directive level. This can be used to silently reduce the possible experiment definitions, without creating errors.
Tests and documentation are added as well.