Add ontapSource field to Netapp Backup#17555
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e166d77: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_netapp_backup" "primary" {
ontap_source {
snapshot_uuid = # value needed
storage_pool = # value needed
volume_uuid = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @ravisankardanda99, @shuyama1 VCR tests complete for e166d77! |
e166d77 to
e8c61a5
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e8c61a5: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_netapp_backup" "primary" {
ontap_source {
snapshot_uuid = # value needed
storage_pool = # value needed
volume_uuid = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @ravisankardanda99, @shuyama1 VCR tests complete for e8c61a5! |
|
An acceptance test was not added for the new Multi-Provider Dependency: Creating an ONTAP-mode volume to get a valid volume_uuid requires the third-party NetApp/netapp-ontap provider. The google provider cannot manage these volumes. CI Limitation: The Magic Modules CI pipeline does not include or support this third-party provider binary API Validation: We cannot use dummy/mock UUIDs because the GCNV API performs strict validation, causing immediate 400/404 errors during creation. |
e8c61a5 to
5fc06b4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5fc06b4: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_netapp_backup" "primary" {
ontap_source {
snapshot_uuid = # value needed
storage_pool = # value needed
volume_uuid = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @ravisankardanda99, @shuyama1 VCR tests complete for 5fc06b4! |
shuyama1
left a comment
There was a problem hiding this comment.
Can you add a test please? Thanks! immutable: true
| - name: 'storagePool' | ||
| type: String | ||
| description: | | ||
| Name of the storage pool. This must be specified for creating backups for ONTAP mode volumes. | ||
| Format: `projects/{{project}}/locations/{{location}}/storagePools/{{storage_pool_id}}` | ||
| required: true | ||
| - name: 'volumeUuid' | ||
| type: String | ||
| description: | | ||
| The UUID of the ONTAP source volume. | ||
| required: true | ||
| - name: 'snapshotUuid' | ||
| type: String | ||
| description: | | ||
| The UUID of the ONTAP source snapshot. |
There was a problem hiding this comment.
Are these subfields also immutable? If so, they'll need immutable: true explicitly
There was a problem hiding this comment.
Added immutable: true to subfields as well.
As mentioned in #17555 (comment), it is not possible to add an acceptance test for this change.
5fc06b4 to
d662014
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d662014: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_netapp_backup" "primary" {
ontap_source {
snapshot_uuid = # value needed
storage_pool = # value needed
volume_uuid = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @ravisankardanda99, @shuyama1 VCR tests complete for d662014! |
shuyama1
left a comment
There was a problem hiding this comment.
An acceptance test was not added for the new
ontapSourcefield because:Multi-Provider Dependency: Creating an ONTAP-mode volume to get a valid volume_uuid requires the third-party NetApp/netapp-ontap provider. The google provider cannot manage these volumes.
CI Limitation: The Magic Modules CI pipeline does not include or support this third-party provider binary
API Validation: We cannot use dummy/mock UUIDs because the GCNV API performs strict validation, causing immediate 400/404 errors during creation.
Sorry for missing this comment. Could you test it locally? We'd generally need some sort of testing to verify this is working. Local testing should be fine!
|
Local testing result: |
shuyama1
left a comment
There was a problem hiding this comment.
Thanks for testing it locally!
8b7eeb7
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.