Skip to content

Moved remaining bootstrap functions to service packages#17550

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-6
May 15, 2026
Merged

Moved remaining bootstrap functions to service packages#17550
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:split-bootstrap-6

Conversation

@melinath
Copy link
Copy Markdown
Member

It turns out there's still one set of references to service packages after this change: provider_test_utils. I'd initially split it out from bootstrap_test_utils; turns out that was a mistake. I need to think some more about how to handle that, so I've left it out from this PR.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@melinath

This comment was marked as outdated.

@melinath
Copy link
Copy Markdown
Member Author

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c2dc5a0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 641 files changed, 1157 insertions(+), 463 deletions(-)
google-beta provider View Diff 720 files changed, 1280 insertions(+), 483 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6427 5716 658 53
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 53 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBigqueryDatasetIamBinding
  • TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
  • TestAccCESApp_update
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeAutoscaler_multicondition
  • TestAccComputeAutoscaler_scaleDownControl
  • TestAccComputeAutoscaler_scaleInControl
  • TestAccComputeAutoscaler_scaleInControlFixed
  • TestAccComputeAutoscaler_scalingSchedule
  • TestAccComputeAutoscaler_update
  • TestAccComputeForwardingRule_forwardingRuleBasicExample
  • TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
  • TestAccComputeForwardingRule_ip
  • TestAccComputeForwardingRule_networkTier
  • TestAccComputeForwardingRule_serviceDirectoryRegistrations
  • TestAccComputeForwardingRule_update
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRegionAutoscaler_scaleDownControl
  • TestAccComputeRegionAutoscaler_scaleInControl
  • TestAccComputeRegionAutoscaler_scalingSchedule
  • TestAccComputeRegionAutoscaler_update
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
  • TestAccComputeTargetPool_update
  • TestAccComputeTargetPool_withSecurityPolicy
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataSourceGoogleComputeInstanceGroupManager
  • TestAccDataSourceGoogleComputeRegionInstanceGroupManager
  • TestAccDataSourceGoogleForwardingRule
  • TestAccDataSourceGoogleForwardingRules
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload
  • TestAccInstanceGroupManager_autoHealingPolicies
  • TestAccInstanceGroupManager_basic
  • TestAccInstanceGroupManager_self_link_unique
  • TestAccInstanceGroupManager_stateful
  • TestAccInstanceGroupManager_update
  • TestAccInstanceGroupManager_waitForStatus
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccModelArmorTemplate_noTemplateMetadataNoDrift
  • TestAccModelArmorTemplate_removeTemplateMetadata
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccRegionInstanceGroupManager_autoHealingPolicies
  • TestAccRegionInstanceGroupManager_basic
  • TestAccRegionInstanceGroupManager_update
  • TestAccServiceAccount_basic

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBigqueryDatasetIamBinding
✅ Log TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
✅ Log TestAccCESApp_update
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeAutoscaler_multicondition
✅ Log TestAccComputeAutoscaler_scaleDownControl
✅ Log TestAccComputeAutoscaler_scaleInControl
✅ Log TestAccComputeAutoscaler_scaleInControlFixed
✅ Log TestAccComputeAutoscaler_scalingSchedule
✅ Log TestAccComputeAutoscaler_update
✅ Log TestAccComputeForwardingRule_forwardingRuleBasicExample
✅ Log TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
✅ Log TestAccComputeForwardingRule_networkTier
✅ Log TestAccComputeForwardingRule_serviceDirectoryRegistrations
✅ Log TestAccComputeForwardingRule_update
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log TestAccComputeRegionAutoscaler_scaleDownControl
✅ Log TestAccComputeRegionAutoscaler_scaleInControl
✅ Log TestAccComputeRegionAutoscaler_scalingSchedule
✅ Log TestAccComputeRegionAutoscaler_update
✅ Log TestAccComputeTargetPool_update
✅ Log TestAccComputeTargetPool_withSecurityPolicy
✅ Log TestAccDataSourceGoogleComputeInstanceGroupManager
✅ Log TestAccDataSourceGoogleComputeRegionInstanceGroupManager
✅ Log TestAccDataSourceGoogleForwardingRule
✅ Log TestAccDataSourceGoogleForwardingRules
✅ Log TestAccInstanceGroupManager_autoHealingPolicies
✅ Log TestAccInstanceGroupManager_basic
✅ Log TestAccInstanceGroupManager_self_link_unique
✅ Log TestAccInstanceGroupManager_stateful
✅ Log TestAccInstanceGroupManager_update
✅ Log TestAccInstanceGroupManager_waitForStatus
✅ Log TestAccModelArmorTemplate_noTemplateMetadataNoDrift
✅ Log TestAccModelArmorTemplate_removeTemplateMetadata
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log TestAccRegionInstanceGroupManager_autoHealingPolicies
✅ Log TestAccRegionInstanceGroupManager_basic
✅ Log TestAccRegionInstanceGroupManager_update
✅ Log TestAccServiceAccount_basic
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccComputeForwardingRule_ip
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccEphemeralServiceAccountKey_create
❌ Error · Log - TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath VCR tests complete for c2dc5a0!

@melinath
Copy link
Copy Markdown
Member Author

VCR failures look unrelated; the VCR invalidations are from the broader VCR issue today.

@melinath melinath requested a review from SirGitsalot May 14, 2026 22:25
@melinath melinath added this pull request to the merge queue May 15, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b7128eb May 15, 2026
22 of 23 checks passed
@melinath melinath deleted the split-bootstrap-6 branch May 15, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants