Moved remaining bootstrap functions to service packages#17550
Merged
Conversation
7f40029 to
c2dc5a0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
/gcbrun |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c2dc5a0: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 53 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
Member
Author
|
VCR failures look unrelated; the VCR invalidations are from the broader VCR issue today. |
SirGitsalot
approved these changes
May 15, 2026
Merged
via the queue into
GoogleCloudPlatform:main
with commit May 15, 2026
b7128eb
22 of 23 checks passed
This was referenced May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out there's still one set of references to service packages after this change: provider_test_utils. I'd initially split it out from bootstrap_test_utils; turns out that was a mistake. I need to think some more about how to handle that, so I've left it out from this PR.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.