add is_missing_in_cai attribute to encryption key fields in compute#17548
add is_missing_in_cai attribute to encryption key fields in compute#17548harshulsoni wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@harshulsoni , can you share more context for this PR? Thanks. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a2f10dc: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_machine_image" "primary" {
machine_image_encryption_key {
raw_key = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @harshulsoni, @zli82016 VCR tests complete for a2f10dc! |
|
@zli82016 this is for an internal bug b/510911000. Updated the PR description to give more details. |
|
@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Add is_missing_in_cai attribute to encryption key fields in compute. This prevents the user-provided raw encryption key to be exported to Google Cloud Asset Inventory (CAI) during Terraform's CAI export process. CAI is frequently used, and exporting encryption keys into asset inventory pipelines defeats the purpose of Customer Suppled Encryption Keys (CSEK).