Remove test-only Framework resources

[c2thorn]

Remove test-only Framework resources

Description

This PR removes three test-only Framework resources/data sources and their associated code from the magic-modules repository:

• NewComputeNetworkFWDataSource
• NewGooglePubsubLiteReservationFWResource
• NewSQLUserFWResource

These resources were only used as helpers in acceptance tests (registered in vcr_utils.go) and were not exposed to users.

Why

The primary goal of this removal is to reduce the number of dependencies needed for ongoing internal work, simplifying the build graph and removing unnecessary files.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[melinath]

LGTM, thanks!

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ccfdcd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 3 insertions(+), 1133 deletions(-)
google-beta provider	View Diff	4 files changed, 3 insertions(+), 1133 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6427	5715	658	54

Affected Service Packages

• All service packages are affected

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 54 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccBigqueryDatasetIamBinding
• TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
• TestAccCESApp_update
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccComputeAutoscaler_autoscalerBasicExample
• TestAccComputeAutoscaler_autoscalerSingleInstanceExample
• TestAccComputeAutoscaler_multicondition
• TestAccComputeAutoscaler_scaleDownControl
• TestAccComputeAutoscaler_scaleInControl
• TestAccComputeAutoscaler_scaleInControlFixed
• TestAccComputeAutoscaler_scalingSchedule
• TestAccComputeAutoscaler_update
• TestAccComputeForwardingRule_forwardingRuleBasicExample
• TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
• TestAccComputeForwardingRule_ip
• TestAccComputeForwardingRule_networkTier
• TestAccComputeForwardingRule_serviceDirectoryRegistrations
• TestAccComputeForwardingRule_update
• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
• TestAccComputeRegionAutoscaler_scaleDownControl
• TestAccComputeRegionAutoscaler_scaleInControl
• TestAccComputeRegionAutoscaler_scalingSchedule
• TestAccComputeRegionAutoscaler_update
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
• TestAccComputeTargetPool_update
• TestAccComputeTargetPool_withSecurityPolicy
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataSourceGoogleComputeInstanceGroupManager
• TestAccDataSourceGoogleComputeRegionInstanceGroupManager
• TestAccDataSourceGoogleFWNetwork
• TestAccDataSourceGoogleForwardingRule
• TestAccDataSourceGoogleForwardingRules
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccEphemeralServiceAccountKey_create
• TestAccEphemeralServiceAccountKey_upload
• TestAccInstanceGroupManager_autoHealingPolicies
• TestAccInstanceGroupManager_basic
• TestAccInstanceGroupManager_self_link_unique
• TestAccInstanceGroupManager_stateful
• TestAccInstanceGroupManager_update
• TestAccInstanceGroupManager_waitForStatus
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccModelArmorTemplate_noTemplateMetadataNoDrift
• TestAccModelArmorTemplate_removeTemplateMetadata
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample
• TestAccRegionInstanceGroupManager_autoHealingPolicies
• TestAccRegionInstanceGroupManager_basic
• TestAccRegionInstanceGroupManager_update
• TestAccServiceAccount_basic

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccBigqueryDatasetIamBinding
✅ Log	✅	TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
✅ Log	✅	TestAccCESApp_update
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeAutoscaler_multicondition
✅ Log	✅	TestAccComputeAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControlFixed
✅ Log	✅	TestAccComputeAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeAutoscaler_update
✅ Log	✅	TestAccComputeForwardingRule_forwardingRuleBasicExample
✅ Log	✅	TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
✅ Log	✅	TestAccComputeForwardingRule_networkTier
✅ Log	✅	TestAccComputeForwardingRule_serviceDirectoryRegistrations
✅ Log	✅	TestAccComputeForwardingRule_update
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeRegionAutoscaler_update
✅ Log	✅	TestAccComputeTargetPool_update
✅ Log	✅	TestAccComputeTargetPool_withSecurityPolicy
✅ Log	✅	TestAccDataSourceGoogleComputeInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleComputeRegionInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleForwardingRule
✅ Log	✅	TestAccDataSourceGoogleForwardingRules
✅ Log	✅	TestAccInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccInstanceGroupManager_basic
✅ Log	✅	TestAccInstanceGroupManager_self_link_unique
✅ Log	✅	TestAccInstanceGroupManager_stateful
✅ Log	✅	TestAccInstanceGroupManager_update
✅ Log	✅	TestAccInstanceGroupManager_waitForStatus
✅ Log	✅	TestAccModelArmorTemplate_noTemplateMetadataNoDrift
✅ Log	✅	TestAccModelArmorTemplate_removeTemplateMetadata
✅ Log	✅	TestAccRegionInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccRegionInstanceGroupManager_basic
✅ Log	✅	TestAccRegionInstanceGroupManager_update
✅ Log	✅	TestAccServiceAccount_basic
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataSourceGoogleFWNetwork
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for 2ccfdcd!

[melinath]

Looks like the tests that rely on these resources (I only see TestAccDataSourceGoogleFWNetwork in the VCR failures but maybe there are tests that skip VCR?) need to be removed.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 231c977:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	7 files changed, 3 insertions(+), 1417 deletions(-)
google-beta provider	View Diff	7 files changed, 3 insertions(+), 1417 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6427	5750	656	21

Affected Service Packages

• All service packages are affected

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccComputeAutoscaler_autoscalerBasicExample
• TestAccComputeAutoscaler_autoscalerSingleInstanceExample
• TestAccComputeForwardingRule_ip
• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccEphemeralServiceAccountKey_create
• TestAccEphemeralServiceAccountKey_upload
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
• TestAccNetworkConnectivityDestination_update
• TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
• TestAccNetworkConnectivityMulticloudDataTransferConfig_update
• TestAccProjectIamMemberRemove_memberInMultipleBindings
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
✅ Log	❌ Error · Log	TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_update
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_update
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for 231c977!