Skip to content

feat(networkservices): add DNS peering config to AgentGateway:#17545

Open
JamesDuncanNz wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:agentgateway-add-dns-peering
Open

feat(networkservices): add DNS peering config to AgentGateway:#17545
JamesDuncanNz wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:agentgateway-add-dns-peering

Conversation

@JamesDuncanNz
Copy link
Copy Markdown
Contributor

Adds the dnsPeeringConfig nested object under privateConnectivity.egress
on google_network_services_agent_gateway, allowing users to specify
domains, targetProject, and targetNetwork so the gateway resolves
queries via Cloud DNS in a peered VPC.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkservices: added `dns_peering_config` field to `google_network_services_agent_gateway` resource (beta)

@github-actions github-actions Bot requested a review from melinath May 13, 2026 20:54
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b5d3fbd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 30 insertions(+)
google-beta provider View Diff 5 files changed, 164 insertions(+)
terraform-google-conversion View Diff 1 file changed, 55 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
101 58 6 37
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_update
  • TestAccNetworkServicesGateway_minimalSwp
  • TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork
  • TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork
  • TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
  • TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample
  • TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyMultiplePorts
  • TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses
  • TestAccNetworkServicesGateway_swpAllPortsReplace
  • TestAccNetworkServicesGateway_swpAsNextHop
  • TestAccNetworkServicesGateway_swpListenAllPorts
  • TestAccNetworkServicesGateway_swpUpdate
  • TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionObservabilityExample
  • TestAccNetworkServicesLbRouteExtension_validation
  • TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
  • TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_update
  • TestAccNetworkServicesMulticastConsumerAssociation_networkServicesMulticastConsumerAssociationBasicExample
  • TestAccNetworkServicesMulticastConsumerAssociation_networkServicesMulticastConsumerAssociationUpdateExample
  • TestAccNetworkServicesMulticastDomainActivation_networkServicesMulticastDomainActivationBasicExample
  • TestAccNetworkServicesMulticastDomainActivation_networkServicesMulticastDomainActivationUpdateExample
  • TestAccNetworkServicesMulticastDomainGroup_networkServicesMulticastDomainGroupBasicExample
  • TestAccNetworkServicesMulticastDomain_networkServicesMulticastDomainBasicExample
  • TestAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample
  • TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample
  • TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample
  • TestAccNetworkServicesMulticastGroupProducerActivation_networkServicesMulticastGroupProducerActivationBasicExample
  • TestAccNetworkServicesMulticastGroupProducerActivation_networkServicesMulticastGroupProducerActivationUpdateExample
  • TestAccNetworkServicesMulticastGroupRangeActivation_networkServicesMulticastGroupRangeActivationBasicExample
  • TestAccNetworkServicesMulticastGroupRangeActivation_networkServicesMulticastGroupRangeActivationUpdateExample
  • TestAccNetworkServicesMulticastGroupRange_networkServicesMulticastGroupRangeBasicExample
  • TestAccNetworkServicesMulticastGroupRange_networkServicesMulticastGroupRangeUpdate
  • TestAccNetworkServicesMulticastProducerAssociation_networkServicesMulticastProducerAssociationBasicExample
  • TestAccNetworkServicesMulticastProducerAssociation_networkServicesMulticastProducerAssociationUpdateExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccNetworkServicesAuthzExtension_update
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_minimalSwp
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyMultiplePorts
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_swpAllPortsReplace
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_swpAsNextHop
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_swpListenAllPorts
✅ Log ❌ Error · Log TestAccNetworkServicesGateway_swpUpdate
✅ Log ❌ Error · Log TestAccNetworkServicesLbRouteExtension_crossRegionInternalPluginExtension
✅ Log ❌ Error · Log TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionObservabilityExample
✅ Log ❌ Error · Log TestAccNetworkServicesLbRouteExtension_validation
✅ Log ❌ Error · Log TestAccNetworkServicesLbTrafficExtension_crossRegionInternalPluginExtension
✅ Log ❌ Error · Log TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesLbTrafficExtension_update
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastConsumerAssociation_networkServicesMulticastConsumerAssociationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastConsumerAssociation_networkServicesMulticastConsumerAssociationUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomainActivation_networkServicesMulticastDomainActivationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomainActivation_networkServicesMulticastDomainActivationUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomainGroup_networkServicesMulticastDomainGroupBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomain_networkServicesMulticastDomainBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupConsumerActivation_networkServicesMulticastGroupConsumerActivationUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupProducerActivation_networkServicesMulticastGroupProducerActivationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupProducerActivation_networkServicesMulticastGroupProducerActivationUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupRangeActivation_networkServicesMulticastGroupRangeActivationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupRangeActivation_networkServicesMulticastGroupRangeActivationUpdateExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupRange_networkServicesMulticastGroupRangeBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastGroupRange_networkServicesMulticastGroupRangeUpdate
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastProducerAssociation_networkServicesMulticastProducerAssociationBasicExample
✅ Log ❌ Error · Log TestAccNetworkServicesMulticastProducerAssociation_networkServicesMulticastProducerAssociationUpdateExample

Caution

Issues requiring attention before PR completion

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@JamesDuncanNz, @melinath VCR tests complete for b5d3fbd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants