Skip to content

Autoscaler stabilization_period field support#17544

Open
zhanto97 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
zhanto97:autoscaler-stab
Open

Autoscaler stabilization_period field support#17544
zhanto97 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
zhanto97:autoscaler-stab

Conversation

@zhanto97
Copy link
Copy Markdown

This PR adds support for stabilization_period field to google_compute_autoscaler and google_compute_region_autoscaler resources.

This filed is GA in compute API.

Fixes b/509493285.

compute: added `stabilization_period` field to `google_compute_autoscaler` and `google_compute_region_autoscaler` resources

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bd1a35e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 105 insertions(+)
google-beta provider View Diff 8 files changed, 106 insertions(+)
terraform-google-conversion View Diff 8 files changed, 102 insertions(+)
Open in Cloud Shell View Diff 2 files changed, 2 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
1447 1349 93 5
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@zhanto97, @roaks3 VCR tests complete for bd1a35e!

@zhanto97
Copy link
Copy Markdown
Author

Failing tests do not seem to be connected to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants