Skip to content

Add sipConfig to ConversationProfile in Dialogflow#17537

Open
drebes wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
drebes:sip-config
Open

Add sipConfig to ConversationProfile in Dialogflow#17537
drebes wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
drebes:sip-config

Conversation

@drebes
Copy link
Copy Markdown
Contributor

@drebes drebes commented May 13, 2026

Added sipConfig nested object with its fields to ConversationProfile resource. Updated example to use sipConfig and location europe-west1 (more realistic location for SIP related integrations)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dialogflow: added `sip_config` field to `google_dialogflow_conversation_profile` resource (beta)

Added sipConfig nested object with its fields to ConversationProfile resource. Updated example to use sipConfig and location europe-west1.

TAG=agy

CONV=0d5f6ca1-949d-4f61-8b9c-ebbf9dc320d4
@github-actions github-actions Bot requested a review from zli82016 May 13, 2026 12:42
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 16f3191:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 48 insertions(+), 1 deletion(-)
google-beta provider View Diff 4 files changed, 318 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 1 file changed, 120 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_conversation_profile (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_conversation_profile" "primary" {
  sip_config {
    copy_inbound_call_leg_headers   = # value needed
    ignore_reinvite_media_direction = # value needed
    inactive_start                  = # value needed
    keep_conversation_running       = # value needed
    max_audio_recording_duration    = # value needed
    use_multi_sdp_ports             = # value needed
    use_progress                    = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
19 18 0 1
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowConversationProfile_dialogflowConversationProfileBetaBidiExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowConversationProfile_dialogflowConversationProfileBetaBidiExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @zli82016 VCR tests complete for 16f3191!

@zli82016
Copy link
Copy Markdown
Member

zli82016 commented May 14, 2026

resource_dialogflow_conversation_profile_generated_test.go:175: Step 1/3 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_dialogflow_conversation_profile.bidi_profile will be updated in-place
          ~ resource "google_dialogflow_conversation_profile" "bidi_profile" {
                id                 = "projects/xxxx/locations/europe-west1/conversationProfiles/CYX-3yh4SXqZ0aV_FWX4Ew"
                name               = "projects/xxxx/locations/europe-west1/conversationProfiles/CYX-3yh4SXqZ0aV_FWX4Ew"
                # (8 unchanged attributes hidden)
        
              + sip_config {
                  + allow_virtual_agent_interaction = true
                  + create_conversation_on_the_fly  = true
                }
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
POST /v2beta1/projects/xxxx/locations/europe-west1/conversationProfiles?alt=json HTTP/1.1


{
 "automatedAgentConfig": {
  "agent": "projects/xxxx/locations/us/apps/tf-test-app-idtv9bby6u6p"
 },
 "displayName": "tf-test-dialogflow-profile-biditv9bby6u6p",
 "languageCode": "en-US",
 "sipConfig": {
  "allowVirtualAgentInteraction": true,
  "createConversationOnTheFly": true
 },
 "useBidiStreaming": true
}

-----------------------------------------------------
2026/05/13 12:56:44 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------


{
  "name": "projects/xxxx/locations/europe-west1/conversationProfiles/CYX-3yh4SXqZ0aV_FWX4Ew",
  "displayName": "tf-test-dialogflow-profile-biditv9bby6u6p",
  "automatedAgentConfig": {
    "agent": "projects/xxxx/locations/us/apps/tf-test-app-idtv9bby6u6p"
  },
  "languageCode": "en-US",
  "createTime": "2026-05-13T12:56:44.090032Z",
  "updateTime": "2026-05-13T12:56:44.090032Z",
  "useBidiStreaming": true
}

I checked the logs, sipConfig is not in the GET response. Is this an API issue?

@zli82016
Copy link
Copy Markdown
Member

Missing test report
Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_conversation_profile (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_conversation_profile" "primary" {
  sip_config {
    copy_inbound_call_leg_headers   = # value needed
    ignore_reinvite_media_direction = # value needed
    inactive_start                  = # value needed
    keep_conversation_running       = # value needed
    max_audio_recording_duration    = # value needed
    use_multi_sdp_ports             = # value needed
    use_progress                    = # value needed
  }
}

Please add tests for these fields.

Also, this field is updatable. Can you please add the update tests for this new field?

Thanks.

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

Removed min_version: beta from sipConfig in ConversationProfile. Removed restricted fields useMultiSdpPorts and useProgress. Added a new multi-step acceptance test for sipConfig in the handwritten test file, running against the Beta provider to verify full lifecycle.

TAG=agy

CONV=0d5f6ca1-949d-4f61-8b9c-ebbf9dc320d4
@github-actions github-actions Bot requested a review from zli82016 May 15, 2026 11:46
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 15, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 360617c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 352 insertions(+), 1 deletion(-)
google-beta provider View Diff 5 files changed, 357 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 1 file changed, 98 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
20 18 0 2
Affected Service Packages
  • dialogflow

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDialogflowConversationProfile_dialogflowConversationProfileBetaBidiExample
  • TestAccDialogflowConversationProfile_sipConfig

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDialogflowConversationProfile_dialogflowConversationProfileBetaBidiExample
❌ Error · Log - TestAccDialogflowConversationProfile_sipConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@drebes, @zli82016 VCR tests complete for 360617c!

@drebes
Copy link
Copy Markdown
Contributor Author

drebes commented May 15, 2026

@zli82016 I have added the update tests as requested. As for the VCR errors it is related to the visibility changes that haven't fully rolled out yet. I'm working on it and we should retrigger the VCR once the fields are public. I tagged you internally on a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants