Add sipConfig to ConversationProfile in Dialogflow#17537
Conversation
Added sipConfig nested object with its fields to ConversationProfile resource. Updated example to use sipConfig and location europe-west1. TAG=agy CONV=0d5f6ca1-949d-4f61-8b9c-ebbf9dc320d4
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 16f3191: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dialogflow_conversation_profile" "primary" {
sip_config {
copy_inbound_call_leg_headers = # value needed
ignore_reinvite_media_direction = # value needed
inactive_start = # value needed
keep_conversation_running = # value needed
max_audio_recording_duration = # value needed
use_multi_sdp_ports = # value needed
use_progress = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
I checked the logs, |
Please add tests for these fields. Also, this field is updatable. Can you please add the update tests for this new field? Thanks. |
Removed min_version: beta from sipConfig in ConversationProfile. Removed restricted fields useMultiSdpPorts and useProgress. Added a new multi-step acceptance test for sipConfig in the handwritten test file, running against the Beta provider to verify full lifecycle. TAG=agy CONV=0d5f6ca1-949d-4f61-8b9c-ebbf9dc320d4
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 360617c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
|
@zli82016 I have added the update tests as requested. As for the VCR errors it is related to the visibility changes that haven't fully rolled out yet. I'm working on it and we should retrigger the VCR once the fields are public. I tagged you internally on a ticket. |
Added sipConfig nested object with its fields to ConversationProfile resource. Updated example to use sipConfig and location europe-west1 (more realistic location for SIP related integrations)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.