Skip to content

Migrate resource_compute_instant_snapshot_test.go.tmpl resource to use direct HTTP rather than a client library #17534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nsamartsev wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −15
Draft

Migrate resource_compute_instant_snapshot_test.go.tmpl resource to use direct HTTP rather than a client library #17534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions ...rce_compute_instant_snapshot_test.go.tmpl → ...resource_compute_instant_snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,13 @@ import (
"github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/hashicorp/terraform-provider-google/google/acctest"
"github.com/hashicorp/terraform-provider-google/google/envvar"
compute_tpg "github.com/hashicorp/terraform-provider-google/google/services/compute"
"github.com/hashicorp/terraform-provider-google/google/services/tags"
"github.com/hashicorp/terraform-provider-google/google/tpgresource"

{{ if eq $.TargetVersionName `ga` }}
"google.golang.org/api/compute/v1"
{{- else }}
compute "google.golang.org/api/compute/v0.beta"
{{- end }}
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
)

func TestAccComputeInstantSnapshot_basicFeatures(t *testing.T) {
var is compute.InstantSnapshot
var is map[string]interface{}
context := map[string]interface{}{
"random_suffix": acctest.RandString(t, 10),
}
Expand All @@ -41,7 +35,7 @@ func TestAccComputeInstantSnapshot_basicFeatures(t *testing.T) {
}

func TestAccComputeInstantSnapshot_labelsUpdate(t *testing.T) {
var is compute.InstantSnapshot
var is map[string]interface{}
context_1 := map[string]interface{}{
"random_suffix": acctest.RandString(t, 10),
"label_key": "test-1",
Expand Down Expand Up @@ -85,8 +79,7 @@ func TestAccComputeInstantSnapshot_labelsUpdate(t *testing.T) {
})
}


func testAccCheckComputeInstantSnapshotExists(t *testing.T, n, p string, is *compute.InstantSnapshot) resource.TestCheckFunc {
func testAccCheckComputeInstantSnapshotExists(t *testing.T, n, p string, is *map[string]interface{}) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
if !ok {
Expand All @@ -101,17 +94,23 @@ func testAccCheckComputeInstantSnapshotExists(t *testing.T, n, p string, is *com

zone := tpgresource.GetResourceNameFromSelfLink(rs.Primary.Attributes["zone"])

found, err := compute_tpg.NewClient(config, config.UserAgent).InstantSnapshots.Get(
p, zone, rs.Primary.Attributes["name"]).Do()
url := fmt.Sprintf("%sprojects/%s/zones/%s/instantSnapshots/%s", config.ComputeBasePath, p, zone, rs.Primary.Attributes["name"])
found, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
Config: config,
Method: "GET",
Project: p,
RawURL: url,
UserAgent: config.UserAgent,
})
if err != nil {
return err
}

if found.Name != rs.Primary.Attributes["name"] {
if foundName, ok := found["name"].(string); !ok || foundName != rs.Primary.Attributes["name"] {
return fmt.Errorf("Instant Snapshot not found")
}

*is = *found
*is = found

return nil
}
Expand Down
Loading