Fix inconsistent result after apply error when adding CLOUD_IAM_GROUP users with capitalized domain names.#17533
Fix inconsistent result after apply error when adding CLOUD_IAM_GROUP users with capitalized domain names.#17533tmgho122 wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cba522b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccSqlUser_iamGroupUser_capitalizedHostName Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @tmgho122, @malhotrasagar2212 VCR tests complete for cba522b! |
Fixes hashicorp/terraform-provider-google#26509
usernameto account for lowercasing of domain names for MySQL users of typeCLOUD_IAM_GROUP.CLOUD_IAM_GROUPusers have capitalized domain name while ensuring no regressions for Postgres.