Skip to content

Fix inconsistent result after apply error when adding CLOUD_IAM_GROUP users with capitalized domain names.#17533

Open
tmgho122 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
tmgho122:main
Open

Fix inconsistent result after apply error when adding CLOUD_IAM_GROUP users with capitalized domain names.#17533
tmgho122 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
tmgho122:main

Conversation

@tmgho122
Copy link
Copy Markdown

Fixes hashicorp/terraform-provider-google#26509

  • Updated DiffSuppressFunc for user name to account for lowercasing of domain names for MySQL users of type CLOUD_IAM_GROUP.
  • Updated unit tests to cover scenario where MySQL CLOUD_IAM_GROUP users have capitalized domain name while ensuring no regressions for Postgres.
cloudsql: fixed inconsistent result after apply error when adding `users` of type `CLOUD_IAM_GROUP` with capitalized domain names for MySQL

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 13, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/sqladmin-infra and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 20, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cba522b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 128 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 128 insertions(+), 5 deletions(-)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccSqlUser_iamGroupUser_capitalizedHostName
🔴 TestAccSqlUser_postgres_iamGroupUser

Analytics

Total Tests Passed Skipped Affected
154 118 29 7
Affected Service Packages
  • sql

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSqlUser_mysql_createUserWithDatabaseRoles
  • TestAccSqlUser_mysql_updateUserWithDatabaseRoles
  • TestAccSqlUser_password_wo
  • TestAccSqlUser_postgres
  • TestAccSqlUser_postgresAbandon
  • TestAccSqlUser_postgresIAM
  • TestAccSqlUser_postgres_updateUserWithDatabaseRoles

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccSqlUser_mysql_createUserWithDatabaseRoles
✅ Log TestAccSqlUser_mysql_updateUserWithDatabaseRoles
✅ Log TestAccSqlUser_password_wo
✅ Log TestAccSqlUser_postgres
✅ Log TestAccSqlUser_postgresAbandon
✅ Log TestAccSqlUser_postgresIAM
✅ Log TestAccSqlUser_postgres_updateUserWithDatabaseRoles

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@tmgho122, @malhotrasagar2212 VCR tests complete for cba522b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mysql CLOUD_IAM_GROUP user creation error

2 participants