Skip to content

resourceIdentity/MMv1: skip id values that aren't present in resource schema#17532

Merged
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:fix-identity-properties-skip-synthesis
May 14, 2026
Merged

resourceIdentity/MMv1: skip id values that aren't present in resource schema#17532
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:fix-identity-properties-skip-synthesis

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented May 12, 2026

When looking into list mmv1 i noticed a bug where an import_format can be used despite the values not being present in the resource's schema.

This adds a check to prevent schema field from being included in identity schema. An example of this is alloydb_user not including project in the resource schema:

base_url: '{{cluster}}/users'
self_link: '{{cluster}}/users/{{user_id}}'
create_url: '{{cluster}}/users?userId={{user_id}}'
update_verb: 'PATCH'
update_mask: true
import_format:
- 'projects/{{project}}/locations/{{location}}/clusters/{{cluster}}/users/{{user_id}}'

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9098981:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 8 deletions(-)
google-beta provider View Diff 8 files changed, 8 deletions(-)

@BBBmau BBBmau added this pull request to the merge queue May 14, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 1de371e May 14, 2026
22 checks passed
@BBBmau BBBmau deleted the fix-identity-properties-skip-synthesis branch May 14, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants