Skip to content

Add terminal_storage_class and per_unit_storage_throughput fields.#17530

Merged
NickElliot merged 3 commits into
GoogleCloudPlatform:mainfrom
rpgoog:add-hypercompute-ga-fields
May 14, 2026
Merged

Add terminal_storage_class and per_unit_storage_throughput fields.#17530
NickElliot merged 3 commits into
GoogleCloudPlatform:mainfrom
rpgoog:add-hypercompute-ga-fields

Conversation

@rpgoog
Copy link
Copy Markdown
Contributor

@rpgoog rpgoog commented May 12, 2026

Add Terraform support for terminal_storage_class and per_unit_storage_throughput.

hypercomputecluster: added `terminal_storage_class` and `per_unit_storage_throughput` fields to the `google_hypercomputecluster_cluster` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 12, 2026
@github-actions github-actions Bot requested a review from NickElliot May 12, 2026 22:56
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@rpgoog rpgoog force-pushed the add-hypercompute-ga-fields branch from 0dcf1cd to e0f9cbd Compare May 12, 2026 23:02
@rpgoog rpgoog changed the title Add terminalStorageClass and perUnitStorageThroughput fields. Add terminal_storage_class and per_unit_storage_throughput fields. May 12, 2026
@modular-magician modular-magician added service/hypercomputecluster and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 13, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e0f9cbd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 71 insertions(+)
google-beta provider View Diff 4 files changed, 71 insertions(+)
terraform-google-conversion View Diff 1 file changed, 22 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
5 3 1 1
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHypercomputeclusterCluster_new

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccHypercomputeclusterCluster_new

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@rpgoog, @NickElliot VCR tests complete for e0f9cbd!

Copy link
Copy Markdown
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple minor formatting changes + a question!

Comment thread mmv1/products/hypercomputecluster/Cluster.yaml
…ce_hypercomputecluster_cluster_test.go

Co-authored-by: Nick Elliot <nickelliot@google.com>
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 13, 2026
…ce_hypercomputecluster_cluster_test.go

Co-authored-by: Nick Elliot <nickelliot@google.com>
@github-actions github-actions Bot requested a review from NickElliot May 13, 2026 19:01
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 14, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 14, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7824e9d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 71 insertions(+)
google-beta provider View Diff 4 files changed, 71 insertions(+)
terraform-google-conversion View Diff 1 file changed, 22 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
5 4 1 0
Affected Service Packages
  • hypercomputecluster

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@rpgoog, @NickElliot VCR tests complete for 7824e9d!

Copy link
Copy Markdown
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants