test_utils: Add listDisplayName assertion#17369
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8044a3f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. |
|
reviewed the failing tests. They are all unrelated to the changes introduced in this PR |
|
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
melinath
left a comment
There was a problem hiding this comment.
This seems reasonable. It's different from how we extract values other places, though. (Not that it's something that we do much of.)
Is this the expected pattern for List functionality, or are we treading novel ground?
yes, a lot of new methods have been looked into in order to perform query tests with list_resources. We especially see this in generated list-resources where
the work that performs state capturing through binding is done here but a more thorough explanation is being worked on since this would be a testing method that is entirely new to the provider |
f0b07df
Adds a new querycheck that captures the display_name provisioned from the first resource provisioning step without needing to be explicit in query tests
Supports query testing generation in magic-modules that is planned in:
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.