Skip to content

test_utils: Add listDisplayName assertion#17369

Merged
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:list-test-util
May 6, 2026
Merged

test_utils: Add listDisplayName assertion#17369
BBBmau merged 2 commits into
GoogleCloudPlatform:mainfrom
BBBmau:list-test-util

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented Apr 30, 2026

Adds a new querycheck that captures the display_name provisioned from the first resource provisioning step without needing to be explicit in query tests

Supports query testing generation in magic-modules that is planned in:

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@BBBmau BBBmau requested a review from melinath April 30, 2026 23:13
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Apr 30, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8044a3f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 52 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 52 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6385 5718 655 12
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample 🔴 Failed [Error message] [Debug log] -
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccCloudRunService_cloudRunServiceGpuExample 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_updateVersion 🔴 Failed [Error message] [Debug log] -
TestAccContainerCluster_withAutopilotResourceManagerTags 🔴 Failed [Error message] [Debug log] -
TestAccContainerNodePool_withHostMaintenancePolicy 🔴 Failed [Error message] [Debug log] -
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample 🔴 Failed [Error message] [Debug log] -
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample 🔴 Failed [Error message] [Debug log] -
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample 🔴 Failed [Error message] [Debug log] -
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample 🔴 Failed [Error message] [Debug log] -
TestAccPubsubSubscription_pubsubSubscriptionTagsExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@BBBmau, @melinath VCR tests complete for 8044a3f!

@BBBmau
Copy link
Copy Markdown
Collaborator Author

BBBmau commented May 4, 2026

reviewed the failing tests. They are all unrelated to the changes introduced in this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. It's different from how we extract values other places, though. (Not that it's something that we do much of.)

Is this the expected pattern for List functionality, or are we treading novel ground?

@BBBmau
Copy link
Copy Markdown
Collaborator Author

BBBmau commented May 6, 2026

are we treading novel ground?

yes, a lot of new methods have been looked into in order to perform query tests with list_resources. We especially see this in generated list-resources where

  • variables do not match the base_url path value key
  • the field value that is necessary in the list configuration is a HCL attribute path, forcing a state value capture for use in list query configuration.

the work that performs state capturing through binding is done here but a more thorough explanation is being worked on since this would be a testing method that is entirely new to the provider

@BBBmau BBBmau added this pull request to the merge queue May 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit f0b07df May 6, 2026
20 of 21 checks passed
@BBBmau BBBmau deleted the list-test-util branch May 6, 2026 23:28
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants