Skip to content

feat: add support for sparksql magic - #137

Merged
medb merged 7 commits into
GoogleCloudDataproc:mainfrom
fangyh20:magic
Sep 24, 2025
Merged

medb merged 7 commits into
GoogleCloudDataproc:mainfrom
fangyh20:magic

Conversation

@fangyh20

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fangyh20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the interactive data analysis experience for users working with Dataproc Spark Connect by integrating Spark SQL magic commands into Jupyter notebooks. This allows users to write and execute SQL queries directly within their notebook cells, streamlining workflows and improving usability for data manipulation and exploration. The changes also ensure broader compatibility with existing Spark ecosystem tools.

Highlights

  • Spark SQL Magic Commands Integration: Added support for sparksql-magic library, enabling direct execution of Spark SQL queries within Jupyter notebooks for Dataproc Spark Connect sessions.
  • Documentation Update: Updated the README.md with a new section detailing how to use Spark SQL magic commands, including loading the extension, configuring settings, executing queries, and advanced options.
  • Session Compatibility Enhancement: Implemented a change to register the DataprocSparkSession instance as pyspark.sql.SparkSession._instantiatedSession to ensure compatibility with tools and libraries that expect this global SparkSession instance.
  • Dependency Management: Included IPython and sparksql-magic as required dependencies in setup.py and requirements-dev.txt.
  • Integration Tests: Introduced new integration tests to verify the successful loading and functionality of the sparksql-magic library with Dataproc Spark sessions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for sparksql-magic, allowing users to execute Spark SQL queries in Jupyter notebooks. This is achieved by adding the necessary dependencies and a mechanism to register the DataprocSparkSession with pyspark's global session management. The changes include documentation updates in README.md and new integration tests.

My main feedback is on the implementation in google/cloud/dataproc_spark_connect/session.py, where a local import shadows a top-level import. This can cause confusion and should be addressed to improve code clarity.

Comment thread google/cloud/dataproc_spark_connect/session.py Outdated
@fangyh20
fangyh20 requested a review from medb September 11, 2025 23:19
@medb medb changed the title add support for sparksql magic feat: add support for sparksql magic Sep 12, 2025
Comment thread setup.py Outdated
Comment thread google/cloud/dataproc_spark_connect/session.py
@fangyh20
fangyh20 requested a review from medb September 15, 2025 20:32
dborowitz
dborowitz previously approved these changes Sep 17, 2025
Comment thread tests/integration/test_session.py
Comment thread google/cloud/dataproc_spark_connect/session.py
Comment thread google/cloud/dataproc_spark_connect/session.py
Comment thread setup.py Outdated
@fangyh20
fangyh20 requested a review from medb September 24, 2025 00:45
@medb
medb merged commit 274f013 into GoogleCloudDataproc:main Sep 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants